Bug 51968 – WebKit2: Add APIs to WKBundleFrame to get content bounds and scroll offset

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Jeff Miller]

WebKit2: Add APIs to WKBundleFrame to get content bounds and scroll offset

[Jeff Miller]

This is to support the equivalent of IWebFramePrivate::contentBounds() and IWebFramePrivate::scrollOffset from WebKit1.

[Jeff Miller]

Created attachment 78061 [details]
Patch

[Jeff Miller]

Comment on attachment 78061 [details]
Patch

Obsoleting this patch, once https://bugs.webkit.org/show_bug.cgi?id=51970 lands I'll redo the patch to include the parameter names in the header.

[Jeff Miller]

Created attachment 78095 [details]
Patch to add APIs to WKBundleFrame to get content bounds and scroll offset

[Darin Adler]

Comment on attachment 78095 [details]
Patch to add APIs to WKBundleFrame to get content bounds and scroll offset

View in context: https://bugs.webkit.org/attachment.cgi?id=78095&action=review

> WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:145
> +    WKRect contentBounds = { {0, 0}, {0, 0} };

We’d normally put four more spaces in there.

[Jeff Miller]

(In reply to comment #5)
> (From update of attachment 78095 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=78095&action=review
> 
> > WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:145
> > +    WKRect contentBounds = { {0, 0}, {0, 0} };
> 
> We’d normally put four more spaces in there.

Normally, I prefer contentBounds = { 0 }, which avoids any dependency on the internal structure of WKRect, but Sam said he did it this way.  Thanks for reviewing.

[WebKit Commit Bot]

Comment on attachment 78095 [details]
Patch to add APIs to WKBundleFrame to get content bounds and scroll offset

Clearing flags on attachment: 78095

Committed r75171: <http://trac.webkit.org/changeset/75171>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/75171 might have broken GTK Linux 32-bit Release