Bug 5196 – input type=file fields with style=display:none do not post their values

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Glen Scott]

According the the HTML 4 specification:

Hidden controls and controls that are not rendered because of style sheet settings may still be successful.
http://www.w3.org/TR/REC-html40/interact/forms.html#successful-controls

Safari does not submit hidden file input elements.

[Glen Scott]

Updated URL to show a working example of the bug.

[David Kilzer (:ddkilzer)]

Confirmed.  Firefox 1.5 behaves as noted (it submits the element even though it's hidden via style).  Test on Webkit nightly r12619.

This bug may be related to Bug 6926 and Bug 3581 (other hidden-by-style issues).

[David Kilzer (:ddkilzer)]

This is not a regression from Safari 2.0.3 (417.8) on 10.4.4 as it behaves the same way.

Glen, could you attach the current index.php source from your web site to this bug as a test case?  Thanks!

[Glen Scott]

Created attachment 6327 [details]
Source code for test case

[Barry Kaplan]

Curretnly I am using this bug to foil bug http://bugzilla.opendarwin.org/show_bug.cgi?id=8248

[Alexey Proskuryakov]

*** Bug 8584 has been marked as a duplicate of this bug. ***

[Alice Liu]

<rdar://problem/4537384>

[Mark Malone]

and rdar://4537384

[Mark Malone]

that is rdar://4573998

[Darin Adler]

(In reply to comment #9)
> that is rdar://4573998

There's nothing in that bug report (Radar 4573998 ) that mentions hidden file input elements. Mark, if you know that this is indeed what's going on in that bug, then please add some clarification in Radar.

[Darin Adler]

There are multiple ways to be "hidden" by style. I've retitled this to specifically talk about "display:none" as opposed to, say, "visibility:hidden".

[Darin Adler]

Created attachment 14138 [details]
patch with manual test and change log

[Maciej Stachowiak]

r=me

Reading this patch makes me wish we had classes that encapsulated the behavior of different Input types, instead of switch statements all over HTMLInputElement. This will likely become more important as we add support for more kinds of form controls, as suggested by Web Forms 2.

[Darin Adler]

Sending        WebCore/ChangeLog
Sending        WebCore/html/HTMLInputElement.cpp
Adding         WebCore/manual-tests/clear-input-file.html
Sending        WebCore/platform/FileChooser.cpp
Sending        WebCore/platform/FileChooser.h
Sending        WebCore/rendering/RenderFileUploadControl.cpp
Transmitting file data ......
Committed revision 21010.