Bug 51953 - Add a "SessionState" object for IPC messaging
Summary: Add a "SessionState" object for IPC messaging
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
Depends on:
Reported: 2011-01-05 13:56 PST by Brady Eidson
Modified: 2011-01-05 16:33 PST (History)
1 user (show)

See Also:

Patch v1 (11.41 KB, patch)
2011-01-05 13:59 PST, Brady Eidson
darin: review+
beidson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2011-01-05 13:56:30 PST
Add a "SessionState" object for IPC messaging.

This object will include all data necessary to restore a session state, to be shipped from the UIProcess to the WebProcess.

For now, it will start out with the back/forward list and the current index in that list.
Comment 1 Brady Eidson 2011-01-05 13:59:19 PST
Created attachment 78038 [details]
Patch v1
Comment 2 WebKit Review Bot 2011-01-05 14:02:38 PST
Attachment 78038 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/Shared/SessionState.cpp', u'WebKit2/Shared/SessionState.h', u'WebKit2/WebKit2.pro', u'WebKit2/WebKit2.xcodeproj/project.pbxproj', u'WebKit2/win/WebKit2.vcproj']" exit_code: 1
WebKit2/Shared/SessionState.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/Shared/SessionState.cpp:32:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 2 in 6 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2011-01-05 16:33:03 PST