Bug 51943 - Implement word transformation
Summary: Implement word transformation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-05 12:12 PST by Anders Carlsson
Modified: 2011-01-05 14:06 PST (History)
1 user (show)

See Also:

Attachments
Patch (11.04 KB, patch)
2011-01-05 12:16 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (15.93 KB, patch)
2011-01-05 12:50 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-01-05 12:12:37 PST 
Implement word transformation
Comment 1 Anders Carlsson 2011-01-05 12:16:13 PST 
Created attachment 78025 [details]
Patch
Comment 2 Anders Carlsson 2011-01-05 12:19:13 PST 
Committed r75093: <http://trac.webkit.org/changeset/75093>
Comment 3 Anders Carlsson 2011-01-05 12:50:57 PST 
Created attachment 78029 [details]
Patch
Comment 4 Sam Weinig 2011-01-05 13:19:11 PST 
Comment on attachment 78029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78029&action=review

> WebKit2/UIProcess/mac/TextCheckerMac.mm:176
> +    static bool readSmartInsertDeleteEnabledDefault = false;

= false not necessary.  Can't you just do:

static bool smartInsertDeleteEnabled = [[NSUserDefaults standardUserDefaults] boolForKey:WebSmartInsertDeleteEnabled];
return smartInsertDeleteEnabled;

> WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp:73
> +    // FIXME: Why isn't this Mac specific like toggleSmartInsertDeleteEnabled?

I think we enable it on Windows all the time, but some ports want to turn it off.
Comment 5 Anders Carlsson 2011-01-05 13:22:11 PST 
Committed r75098: <http://trac.webkit.org/changeset/75098>
Comment 6 Eric Seidel (no email) 2011-01-05 14:06:48 PST 
I believe this broke the build.