RESOLVED FIXED 51943
Implement word transformation 
https://bugs.webkit.org/show_bug.cgi?id=51943
Summary Implement word transformation
Anders Carlsson
Reported 2011-01-05 12:12:37 PST
Implement word transformation
Attachments
Patch (11.04 KB, patch)
2011-01-05 12:16 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (15.93 KB, patch)
2011-01-05 12:50 PST, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-01-05 12:16:13 PST
Created attachment 78025 [details] Patch
Anders Carlsson
Comment 2 2011-01-05 12:19:13 PST
Committed r75093: <http://trac.webkit.org/changeset/75093>
Anders Carlsson
Comment 3 2011-01-05 12:50:57 PST
Created attachment 78029 [details] Patch
Sam Weinig
Comment 4 2011-01-05 13:19:11 PST
Comment on attachment 78029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78029&action=review > WebKit2/UIProcess/mac/TextCheckerMac.mm:176 > + static bool readSmartInsertDeleteEnabledDefault = false; = false not necessary. Can't you just do: static bool smartInsertDeleteEnabled = [[NSUserDefaults standardUserDefaults] boolForKey:WebSmartInsertDeleteEnabled]; return smartInsertDeleteEnabled; > WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp:73 > + // FIXME: Why isn't this Mac specific like toggleSmartInsertDeleteEnabled? I think we enable it on Windows all the time, but some ports want to turn it off.
Anders Carlsson
Comment 5 2011-01-05 13:22:11 PST
Committed r75098: <http://trac.webkit.org/changeset/75098>
Eric Seidel (no email)
Comment 6 2011-01-05 14:06:48 PST
I believe this broke the build.
Note You need to log in before you can comment on or make changes to this bug.