Bug 51935 - Add WebKit2 API for largest frame
Summary: Add WebKit2 API for largest frame
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2011-01-05 11:04 PST by Alexey Proskuryakov
Modified: 2011-01-05 11:49 PST (History)
3 users (show)

See Also:

proposed patch (1.74 KB, patch)
2011-01-05 11:05 PST, Alexey Proskuryakov
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-01-05 11:04:03 PST
Forgot to publish the new accessor as WK2 API.
Comment 1 Alexey Proskuryakov 2011-01-05 11:05:16 PST
Created attachment 78018 [details]
proposed patch
Comment 2 WebKit Review Bot 2011-01-05 11:06:47 PST
Attachment 78018 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/UIProcess/API/C/WKPage.cpp', u'WebKit2/UIProcess/API/C/WKPage.h']" exit_code: 1
WebKit2/UIProcess/API/C/WKPage.h:271:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2011-01-05 11:19:37 PST
Filed 51938 against check-webkit-style.
Comment 4 Alexey Proskuryakov 2011-01-05 11:49:20 PST
Committed <http://trac.webkit.org/changeset/75089>.