Bug 51911 - GTK: AX: DRT needs to use correct root object method.
Summary: GTK: AX: DRT needs to use correct root object method.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-04 18:07 PST by chris fleizach
Modified: 2011-01-05 10:19 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.93 KB, patch)
2011-01-04 18:10 PST, chris fleizach 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2011-01-04 18:07:24 PST 
GTK needs to get the correct accessibility root object by using axObjectCache() root object.
Comment 1 chris fleizach 2011-01-04 18:10:44 PST 
Created attachment 77958 [details]
Patch
Comment 2 chris fleizach 2011-01-04 18:11:31 PST 
we can also use this bug to address the fact that DRT is crashing a lot now. I need some help figuring out what's going on there, since I can't see the crash logs.
Comment 3 Martin Robinson 2011-01-04 18:36:29 PST 
Here are the crash logs for the GTK+ bots: http://webkit-bots.igalia.com/
Comment 4 chris fleizach 2011-01-04 23:56:12 PST 
looks like i fixed the layout test crashing. i suspect the API tests may still fail, don't know if I can fix those on my own
Comment 5 Martin Robinson 2011-01-05 00:14:24 PST 
Comment on attachment 77958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77958&action=review

Thanks for the fix!

> Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:63
> +    AtkObject* accessible =  DumpRenderTreeSupportGtk::getRootAccessibleElement(mainFrame);

There's an extra space here after =.
Comment 6 chris fleizach 2011-01-05 09:31:58 PST 
http://trac.webkit.org/changeset/75072