WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
51903
Tell UI process which subframe is largest
https://bugs.webkit.org/show_bug.cgi?id=51903
Summary
Tell UI process which subframe is largest
Alexey Proskuryakov
Reported
2011-01-04 15:31:01 PST
Some WebKit clients need to know which frame in a frameset is largest for their UI decisions. They want the answer synchronously. Since UI process doesn't track frame sizes, and we want to keep it that way, it needs to track which frame is largest.
Attachments
proposed patch
(9.39 KB, patch)
2011-01-04 15:40 PST
,
Alexey Proskuryakov
sam
: review+
Details
Formatted Diff
Diff
patch for landing
(9.43 KB, patch)
2011-01-04 16:11 PST
,
Alexey Proskuryakov
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2011-01-04 15:40:08 PST
Created
attachment 77938
[details]
proposed patch Some potential areas of concern: - Is the algorithm what clients want? I reinvented it. - There is no strong guarantee that new data members will be cleared up when frame tree changes. As far as I can tell, WebFrame classes on both sides will not be too upset, but I can't be sure.
Sam Weinig
Comment 2
2011-01-04 15:55:29 PST
Comment on
attachment 77938
[details]
proposed patch I think the names need to indicate that it is the largest frame is in the mainFrame frameset. I am also not sure we really need to be doing this on all contentSize changes, but I don't think it matters.
Alexey Proskuryakov
Comment 3
2011-01-04 16:11:22 PST
Created
attachment 77943
[details]
patch for landing I couldn't come up with better names. The fact that these member variables are in per-page classes should hopefully serve as a hint.
WebKit Commit Bot
Comment 4
2011-01-05 01:33:15 PST
Comment on
attachment 77943
[details]
patch for landing Clearing flags on attachment: 77943 Committed
r75054
: <
http://trac.webkit.org/changeset/75054
>
WebKit Commit Bot
Comment 5
2011-01-05 01:33:21 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug