Bug 51902 – [Qt] [WK2] Add support for non-trivial context menu action

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Benjamin Poulain]

The patch https://bugs.webkit.org/show_bug.cgi?id=51825 added support for the context menu. Now it is time to use it to peform something useful :)

[Kenneth Rohde Christiansen]

(In reply to comment #0)
> The patch https://bugs.webkit.org/show_bug.cgi?id=51825 added support for the context menu. Now it is time to use it to peform something useful :)

You don't seem to like the letter r in the beginning of words: peform and suppot ;-) Let me fix the title!

[Benjamin Poulain]

Created attachment 77937 [details]
Patch

[Benjamin Poulain]

Created attachment 77939 [details]
Patch

I did not mean to remove that blank line.

[Benjamin Poulain]

(In reply to comment #1)
> You don't seem to like the letter r in the beginning of words: peform and suppot ;-) Let me fix the title!

Thanks for fixing the the title. I guess there is too much food in my keyboard for it to work properly ;)

[Kenneth Rohde Christiansen]

Comment on attachment 77939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77939&action=review

Looks good

> WebKit2/UIProcess/API/qt/qwkpage.cpp:604
> +    QAction* qtAction = action(webAction);

So this action() converter was already defined?

[Benjamin Poulain]

(In reply to comment #5)
> > WebKit2/UIProcess/API/qt/qwkpage.cpp:604
> > +    QAction* qtAction = action(webAction);
> 
> So this action() converter was already defined?

Yep, QWKPage::action() seem to be a copy of the design of QWebPage::action(). It is used to get the page action in any context.

Thanks for the review Kenneth.

[WebKit Commit Bot]

Comment on attachment 77939 [details]
Patch

Clearing flags on attachment: 77939

Committed r75047: <http://trac.webkit.org/changeset/75047>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.