Bug 51896 - Send over text checker state to the web process
Summary: Send over text checker state to the web process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-04 14:08 PST by Anders Carlsson
Modified: 2011-01-04 14:55 PST (History)
5 users (show)

See Also:

Attachments
Patch (24.07 KB, patch)
2011-01-04 14:27 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-01-04 14:08:17 PST 
Send over text checker state to the web process
Comment 1 Anders Carlsson 2011-01-04 14:27:19 PST 
Created attachment 77932 [details]
Patch
Comment 2 Sam Weinig 2011-01-04 14:32:54 PST 
Comment on attachment 77932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77932&action=review

Do you need to update WebKit2.pro?

r=me if you fix these issues.

> WebKit2/UIProcess/mac/TextCheckerMac.mm:36
> +TextCheckerState textCheckerState;

Will this cause a static constructor to be called?

> WebKit2/UIProcess/mac/TextCheckerMac.mm:39
> +static void initializeState() {
> +    static bool didInitializeState = false;

{ on the wrong line.  I believe the = false is unnecessary.
Comment 3 Darin Adler 2011-01-04 14:33:02 PST 
Comment on attachment 77932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77932&action=review

> WebKit2/UIProcess/mac/TextCheckerMac.mm:32
> +#define WebAutomaticSpellingCorrectionEnabled @"WebAutomaticSpellingCorrectionEnabled"
> +#define WebContinuousSpellCheckingEnabled @"WebContinuousSpellCheckingEnabled"
> +#define WebGrammarCheckingEnabled @"WebGrammarCheckingEnabled"

Are macros really necessary? Could we do this another way?
Comment 4 Anders Carlsson 2011-01-04 14:41:59 PST 
Committed r75010: <http://trac.webkit.org/changeset/75010>
Comment 5 WebKit Review Bot 2011-01-04 14:54:28 PST 
http://trac.webkit.org/changeset/75010 might have broken Qt Linux Release
Comment 6 Early Warning System Bot 2011-01-04 14:55:18 PST 
Attachment 77932 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7216409
Comment 7 Build Bot 2011-01-04 14:55:24 PST 
Attachment 77932 [details] did not build on win:
Build output: http://queues.webkit.org/results/7237406