Bug 51896 – Send over text checker state to the web process

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Send over text checker state to the web process

[Anders Carlsson]

Created attachment 77932 [details]
Patch

[Sam Weinig]

Comment on attachment 77932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77932&action=review

Do you need to update WebKit2.pro?

r=me if you fix these issues.

> WebKit2/UIProcess/mac/TextCheckerMac.mm:36
> +TextCheckerState textCheckerState;

Will this cause a static constructor to be called?

> WebKit2/UIProcess/mac/TextCheckerMac.mm:39
> +static void initializeState() {
> +    static bool didInitializeState = false;

{ on the wrong line.  I believe the = false is unnecessary.

[Darin Adler]

Comment on attachment 77932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77932&action=review

> WebKit2/UIProcess/mac/TextCheckerMac.mm:32
> +#define WebAutomaticSpellingCorrectionEnabled @"WebAutomaticSpellingCorrectionEnabled"
> +#define WebContinuousSpellCheckingEnabled @"WebContinuousSpellCheckingEnabled"
> +#define WebGrammarCheckingEnabled @"WebGrammarCheckingEnabled"

Are macros really necessary? Could we do this another way?

[Anders Carlsson]

Committed r75010: <http://trac.webkit.org/changeset/75010>

[WebKit Review Bot]

http://trac.webkit.org/changeset/75010 might have broken Qt Linux Release

[Early Warning System Bot]

Attachment 77932 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7216409

[Build Bot]

Attachment 77932 [details] did not build on win:
Build output: http://queues.webkit.org/results/7237406