Bug 51887 - [GTK] Use the default CSS text input control border width of relying on the GTK+ theme
Summary: [GTK] Use the default CSS text input control border width of relying on the G...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-01-04 12:16 PST by Martin Robinson
Modified: 2011-01-04 14:59 PST (History)
0 users

See Also:

Attachments
Patch (144.04 KB, patch)
2011-01-04 13:42 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-01-04 12:16:45 PST 
GTK+ themes generally have text control border widths between 1 and 3 pixels. The html.css border widths (2 pixels for text input controls and 1 pixel for text area controls) seem to produce rendering results that are fine for every theme I've tested. Removing this variation between GTK+ themes will:

1. Remove some code.
2. Ensure consistent DRT results between GTK 2.x and GTK 3.x.
3. Protect the DRT results from future theme changes.

The current default GTK 2.x theme has a border width of 2 pixels, so this change should only require updating results that have text areas.
Comment 1 Martin Robinson 2011-01-04 13:42:06 PST 
Created attachment 77925 [details]
Patch
Comment 2 Xan Lopez 2011-01-04 14:13:19 PST 
Comment on attachment 77925 [details]
Patch

OK, let's do this.
Comment 3 Xan Lopez 2011-01-04 14:13:34 PST 
Comment on attachment 77925 [details]
Patch

I was saying...
Comment 4 Martin Robinson 2011-01-04 14:58:55 PST 
Comment on attachment 77925 [details]
Patch

Clearing flags on attachment: 77925

Committed r75016: <http://trac.webkit.org/changeset/75016>
Comment 5 Martin Robinson 2011-01-04 14:59:00 PST 
All reviewed patches have been landed.  Closing bug.