Bug 51877 - Web Inspector: [regression] Cookies view does not allow columns resize.
Summary: Web Inspector: [regression] Cookies view does not allow columns resize.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-04 09:36 PST by Pavel Feldman
Modified: 2011-01-11 05:18 PST (History)
11 users (show)

See Also:


Attachments
[PATCH] Proposed change (1.12 KB, patch)
2011-01-04 09:37 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-01-04 09:36:01 PST
Patch to follow.
Comment 1 Pavel Feldman 2011-01-04 09:37:28 PST
Created attachment 77895 [details]
[PATCH] Proposed change
Comment 2 Joseph Pecoraro 2011-01-05 04:47:13 PST
Comment on attachment 77895 [details]
[PATCH] Proposed change

When did this regress?
Comment 3 Joseph Pecoraro 2011-01-05 05:16:26 PST
Comment on attachment 77895 [details]
[PATCH] Proposed change

All updates go through this function, so this might work on updates work,  What problem is this fixing? Shouldn't the resize event on the datagrid already handle this? I see one defined on the simple cookie table, but not the advanced. I see the datagrid fires a "width changed" event on resize changes, that might be good to tap into. I'm in a car so I can't quite fully verify :(.
Comment 4 Pavel Feldman 2011-01-11 04:57:30 PST
> All updates go through this function, so this might work on updates work,  What problem is this fixing? Shouldn't the resize event on the datagrid already handle this? I see one defined on the simple cookie table, but not the advanced. I see the datagrid fires a "width changed" event on resize changes, that might be good to tap into. I'm in a car so I can't quite fully verify :(.

Ok, to repro:

1. pull up
2. stop engine
3. run webkit nightly
4. try resizing cookies table columns :)
Comment 5 WebKit Commit Bot 2011-01-11 05:18:02 PST
Comment on attachment 77895 [details]
[PATCH] Proposed change

Clearing flags on attachment: 77895

Committed r75489: <http://trac.webkit.org/changeset/75489>
Comment 6 WebKit Commit Bot 2011-01-11 05:18:08 PST
All reviewed patches have been landed.  Closing bug.