Bug 51872 - Rename the existing YARR files and classes
Summary: Rename the existing YARR files and classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Peter Varga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-04 07:27 PST by Peter Varga
Modified: 2011-01-10 13:08 PST (History)
5 users (show)

See Also:


Attachments
proposed patch (568.69 KB, patch)
2011-01-04 07:32 PST, Peter Varga
barraclough: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Varga 2011-01-04 07:27:20 PST
Currently the name of YARR files and classes start with a "Regex" prefix. This naming convention can be a bit confusing
because the term RegExp is generally used in JavaScriptCore.
The prefixes of YARR names should be changed to make the parts of YARR more seperable from the JavaScriptCore.
Comment 1 Peter Varga 2011-01-04 07:32:15 PST
Created attachment 77886 [details]
proposed patch
Comment 2 Gavin Barraclough 2011-01-06 14:13:02 PST
Comment on attachment 77886 [details]
proposed patch

Looks great Peter.
Comment 3 WebKit Commit Bot 2011-01-06 14:15:12 PST
Comment on attachment 77886 [details]
proposed patch

Rejecting attachment 77886 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'apply-attachment', '--no-update', '--non-interactive', 77886]" exit_code: 2
Last 500 characters of output:
ore/yarr/YarrPattern.cpp
patching file Source/JavaScriptCore/yarr/YarrPattern.h
(Stripping trailing CRs from patch.)
patching file Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj
Hunk #1 FAILED at 1652.
1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj.rej

Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Gavin Barraclough', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7351049
Comment 4 Gavin Barraclough 2011-01-10 13:08:50 PST
Landed in r75421.