RESOLVED FIXED 51870
[GTK] Port text input control painting to GtkStyleContext 
https://bugs.webkit.org/show_bug.cgi?id=51870
Summary [GTK] Port text input control painting to GtkStyleContext
Carlos Garcia Campos
Reported 2011-01-04 03:11:42 PST
This depends on bug #51764 since the patch for stock icons contains the initial GtkStyleContext port. I'm wondering whether we really need setTextInputBorders() method, other ports don't implement adjustTextFieldStyle() and adjustTextAreaStyle() and I don't see any difference when not using them with gtk.
Attachments
Patch to use GtkStyleContext to paint text input controls (3.06 KB, patch)
2011-01-05 04:24 PST, Carlos Garcia Campos 		mrobinson: review-
DetailsFormatted DiffDiff
Updated patch using adjustRepaintRect() (4.53 KB, patch)
2011-01-10 02:03 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-01-05 04:24:16 PST
Created attachment 77987 [details] Patch to use GtkStyleContext to paint text input controls
Martin Robinson
Comment 2 2011-01-05 12:26:35 PST
Comment on attachment 77987 [details] Patch to use GtkStyleContext to paint text input controls I think we should use adjustRepaintRect to paint exterior focus outside the actual text box rect. This will ensure that a large exterior focus doesn't shrink the text box greatly.
Carlos Garcia Campos
Comment 3 2011-01-10 02:03:50 PST
Created attachment 78383 [details] Updated patch using adjustRepaintRect()
WebKit Review Bot
Comment 4 2011-01-10 02:05:51 PST
Attachment 78383 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/gtk/RenderThemeGtk3.cpp']" exit_code: 1 Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:139: Use 0 instead of NULL. [readability/null] [5] Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:370: Use 0 instead of NULL. [readability/null] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Martin Robinson
Comment 5 2011-01-10 08:22:44 PST
Comment on attachment 78383 [details] Updated patch using adjustRepaintRect() Nice. GtkStyleContext really simplifies things.
Carlos Garcia Campos
Comment 6 2011-01-10 09:01:13 PST
Committed r75378: <http://trac.webkit.org/changeset/75378>
Note You need to log in before you can comment on or make changes to this bug.