After http://trac.webkit.org/changeset/73362, the default focus ring in Qt is too wide. Some ideas of how to fix it: 1. Make the default configurable. 2. Use a gradient to draw the focus ring, like the mac port does, so it does not look so wide. 3. Not support the width of outline-width. 4. ???
Created attachment 78036 [details] Intermediate step: use QPalette::Highlight instead of black
Comment on attachment 78036 [details] Intermediate step: use QPalette::Highlight instead of black re=me
(In reply to comment #1) > Created an attachment (id=78036) [details] > Intermediate step: use QPalette::Highlight instead of black Thanks for doing this! I was looking for a QStyle API for color selection, and did not find any:( <https://bugs.webkit.org/show_bug.cgi?id=50325#c6>
Comment on attachment 78036 [details] Intermediate step: use QPalette::Highlight instead of black Clearing flags on attachment: 78036 Committed r75126: <http://trac.webkit.org/changeset/75126>
All reviewed patches have been landed. Closing bug.
This was an intermediate fix.
After https://bugs.webkit.org/show_bug.cgi?id=52612 is fixed, we could easily change the default width of the focus ring.
Created attachment 82011 [details] Patch to fix the ugly focus ring This patch fix the ugly focus ring by ignoring the width if :focus has an outline set. Like many other ports we choose the nice looking option.
Comment on attachment 82011 [details] Patch to fix the ugly focus ring Needs ChangeLog. I agree with patch otherwise, our focus rings are way too ugly right now.
Created attachment 82012 [details] Patch to fix the ugly focus ring This patch fix the ugly focus ring by ignoring the width if :focus has an outline set. Like many other ports we choose the nice looking option. Changelog for some weird reason was not in the diff.
Created attachment 82013 [details] Patch to fix the ugly focus ring This patch fix the ugly focus ring by ignoring the width if :focus has an outline set. Like many other ports we choose the nice looking option. With ChangeLog
Comment on attachment 82013 [details] Patch to fix the ugly focus ring r=me
Comment on attachment 82013 [details] Patch to fix the ugly focus ring Clearing flags on attachment: 82013 Committed r78259: <http://trac.webkit.org/changeset/78259>