Bug 51850 - Put CFNetwork loader code inside USE(CFNETWORK)
Summary: Put CFNetwork loader code inside USE(CFNETWORK)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords:
Depends on:
Blocks: 51836
  Show dependency treegraph
 
Reported: 2011-01-03 13:39 PST by Pratik Solanki
Modified: 2011-01-03 17:00 PST (History)
4 users (show)

See Also:


Attachments
Patch (34.06 KB, patch)
2011-01-03 14:48 PST, Pratik Solanki
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2011-01-03 13:39:28 PST
As part of fixing bug 51836, we need to put all CFNetwork files inside #if USE(CFNETWORK). Corresponding Mac code that uses Foundation should be put under #if !USE(CFNETWORK). Then we can add all the CFNetwork files to the WebCore xcode project.
Comment 1 Pratik Solanki 2011-01-03 14:48:51 PST
Created attachment 77848 [details]
Patch
Comment 2 Pratik Solanki 2011-01-03 15:46:48 PST
Committed r74943 - <http://trac.webkit.org/changeset/74943>
Comment 3 WebKit Review Bot 2011-01-03 16:18:54 PST
http://trac.webkit.org/changeset/74943 might have broken Windows Release (Build) and Windows Debug (Build)
Comment 4 Pratik Solanki 2011-01-03 17:00:46 PST
Follow on commits to fix build breakage

http://trac.webkit.org/changeset/74948
http://trac.webkit.org/changeset/74949