Bug 51847 - Shrink RootInlineBox
Summary: Shrink RootInlineBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-03 13:17 PST by mitz
Modified: 2011-01-03 14:10 PST (History)
3 users (show)

See Also:

Attachments
Roll m_baselineType into a bitfield (1.04 KB, patch)
2011-01-03 13:20 PST, mitz 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2011-01-03 13:17:59 PST 
Shrink RootInlineBox
Comment 1 mitz 2011-01-03 13:20:20 PST 
Created attachment 77839 [details]
Roll m_baselineType into a bitfield
Comment 2 Darin Adler 2011-01-03 13:24:46 PST 
Comment on attachment 77839 [details]
Roll m_baselineType into a bitfield

Did you test whether this works properly on Windows? I seem to recall that on Windows bitfields are signed so the 1 value ends up being -1. Sometimes we have to use the type unsigned instead of the actual enum type to work around that. r=m if this doesn't break with MSVC.
Comment 3 mitz 2011-01-03 13:42:00 PST 
Committed r74937.
<http://trac.webkit.org/projects/webkit/changeset/74937>
Comment 4 WebKit Review Bot 2011-01-03 14:10:37 PST 
http://trac.webkit.org/changeset/74937 might have broken SnowLeopard Intel Release (Build)