WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
51845
CSS3 gradients with em-based stops fail to repaint when font size changes
https://bugs.webkit.org/show_bug.cgi?id=51845
Summary
CSS3 gradients with em-based stops fail to repaint when font size changes
Simon Fraser (smfr)
Reported
2011-01-03 12:24:32 PST
CSS3 gradients allow use of various units to control color stop position, including 'em'. However, we cache gradients based purely on size, so fail to repaint them when just font size changes.
Attachments
Patch
(10.43 KB, patch)
2011-01-29 12:32 PST
,
Simon Fraser (smfr)
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2011-01-05 22:56:19 PST
It may also be that a gradient shared between two renderers with different font sizes does not render correctly in one of them.
Simon Fraser (smfr)
Comment 2
2011-01-29 12:32:47 PST
Created
attachment 80570
[details]
Patch
Eric Seidel (no email)
Comment 3
2011-01-30 03:51:20 PST
Comment on
attachment 80570
[details]
Patch Hmm... I wonder how many other places we get this wrong. :)
mitz
Comment 4
2011-01-30 09:47:49 PST
Comment on
attachment 80570
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=80570&action=review
> Source/WebCore/css/CSSGradientValue.cpp:412 > + for (size_t i = 0; i < m_stops.size(); i++) {
Please change this to ++i.
Simon Fraser (smfr)
Comment 5
2011-01-30 10:20:13 PST
http://trac.webkit.org/changeset/77089
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug