RESOLVED FIXED51840
webkit-patch shouldn't waste time cleaning a working directory that's already clean 
https://bugs.webkit.org/show_bug.cgi?id=51840
Summary webkit-patch shouldn't waste time cleaning a working directory that's already...
Adam Barth
Reported 2011-01-03 11:43:24 PST
webkit-patch shouldn't waste time cleaning a working directory that's already clean
Attachments
Patch (1.59 KB, patch)
2011-01-03 11:44 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-01-03 11:44:51 PST
Created attachment 77832 [details] Patch
Eric Seidel (no email)
Comment 2 2011-01-03 11:47:21 PST
Comment on attachment 77832 [details] Patch I believe this was done this way to avoid doing the "is clean" check at all if --force-clean was passed.
Adam Barth
Comment 3 2011-01-03 11:50:48 PST
According to perf measurements, that seems to be a backwards optimization. :) Cleaning working directory webkitpy.common.system: [DEBUG] "svn cleanup" took 14.47s webkitpy.common.system: [DEBUG] "svn --version --quiet" took 0.02s webkitpy.common.system: [DEBUG] "svn status" took 4.55s webkitpy.common.system: [DEBUG] "svn revert -R ." took 45.45s
Eric Seidel (no email)
Comment 4 2011-01-03 11:55:27 PST
I wonder how it compares for git, since I'm sure that code was written for git. :) But I'm willing to believe it reamains backwards for git.
WebKit Commit Bot
Comment 5 2011-01-03 12:40:35 PST
Comment on attachment 77832 [details] Patch Clearing flags on attachment: 77832 Committed r74925: <http://trac.webkit.org/changeset/74925>
WebKit Commit Bot
Comment 6 2011-01-03 12:40:41 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2011-01-03 14:22:38 PST
http://trac.webkit.org/changeset/74925 might have broken Leopard Intel Debug (Tests)
Note You need to log in before you can comment on or make changes to this bug.