RESOLVED FIXED 51827
In the cmake build system move logic related to ENABLE_NOTIFICATIONS into its own block. 
https://bugs.webkit.org/show_bug.cgi?id=51827
Summary In the cmake build system move logic related to ENABLE_NOTIFICATIONS into its...
Benjamin Meyer
Reported 2011-01-03 10:16:09 PST
Just like with ENABLE_FILE_SYSTEM in the cmake file, unless there is a build issue it is worth putting the ENABLE_NOTIFICATIONS files in a block.
Attachments
proposed solution (2.19 KB, patch)
2011-01-03 10:18 PST, Benjamin Meyer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Meyer
Comment 1 2011-01-03 10:18:02 PST
Created attachment 77817 [details] proposed solution
Patrick R. Gansterer
Comment 2 2011-01-03 10:20:54 PST
LGTM
Daniel Bates
Comment 3 2011-01-03 10:38:58 PST
Comment on attachment 77817 [details] proposed solution This change looks good to both Patrick Gansterer and I. r=me.
WebKit Commit Bot
Comment 4 2011-01-03 11:37:51 PST
Comment on attachment 77817 [details] proposed solution Clearing flags on attachment: 77817 Committed r74916: <http://trac.webkit.org/changeset/74916>
WebKit Commit Bot
Comment 5 2011-01-03 11:37:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.