Bug 51827 – In the cmake build system move logic related to ENABLE_NOTIFICATIONS into its own block.

Bug 51827 - In the cmake build system move logic related to ENABLE_NOTIFICATIONS into its own block.


Summary:	In the cmake build system move logic related to ENABLE_NOTIFICATIONS into its...

Status:	RESOLVED FIXED

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests
Version:	528+ (Nightly build)
Platform:	PC All

Importance:	P2 Normal
Assigned To:	Nobody

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-01-03 10:16 PST by Benjamin Meyer
Modified:	2011-01-03 11:37 PST (History)
CC List:	3 users (show)

See Also:

Attachments
proposed solution (2.19 KB, patch) 2011-01-03 10:18 PST, Benjamin Meyer	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Benjamin Meyer 2011-01-03 10:16:09 PST

Just like with ENABLE_FILE_SYSTEM in the cmake file, unless there is a build issue it is worth putting the ENABLE_NOTIFICATIONS files in a block.

Comment 1 Benjamin Meyer 2011-01-03 10:18:02 PST

Created attachment 77817 [details]
proposed solution

Comment 2 Patrick R. Gansterer 2011-01-03 10:20:54 PST

LGTM

Comment 3 Daniel Bates 2011-01-03 10:38:58 PST

Comment on attachment 77817 [details]
proposed solution

This change looks good to both Patrick Gansterer and I.
r=me.

Comment 4 WebKit Commit Bot 2011-01-03 11:37:51 PST

Comment on attachment 77817 [details]
proposed solution

Clearing flags on attachment: 77817

Committed r74916: <http://trac.webkit.org/changeset/74916>

Comment 5 WebKit Commit Bot 2011-01-03 11:37:56 PST

All reviewed patches have been landed.  Closing bug.