RESOLVED FIXED 51815
[GTK] Port check and radio button painting to GtkStyleContext 
https://bugs.webkit.org/show_bug.cgi?id=51815
Summary [GTK] Port check and radio button painting to GtkStyleContext
Carlos Garcia Campos
Reported 2011-01-03 04:31:12 PST
This depends on bug #51764 since the patch for stock icons contains the initial GtkStyleContext port
Attachments
Paint check and radio buttons with GtkStyleContext API (5.88 KB, patch)
2011-01-03 04:34 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch using adjustRepaintRect() (6.88 KB, patch)
2011-01-10 06:27 PST, Carlos Garcia Campos 		mrobinson: review-
DetailsFormatted DiffDiff
Update patch according to review (6.77 KB, patch)
2011-01-10 09:33 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-01-03 04:34:13 PST
Created attachment 77801 [details] Paint check and radio buttons with GtkStyleContext API
Carlos Garcia Campos
Comment 2 2011-01-10 06:27:59 PST
Created attachment 78396 [details] Updated patch using adjustRepaintRect()
WebKit Review Bot
Comment 3 2011-01-10 06:30:24 PST
Attachment 78396 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/gtk/RenderThemeGtk3.cpp']" exit_code: 1 Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:123: Use 0 instead of NULL. [readability/null] [5] Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:197: Use 0 instead of NULL. [readability/null] [5] Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:218: Use 0 instead of NULL. [readability/null] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Martin Robinson
Comment 4 2011-01-10 08:52:20 PST
Comment on attachment 78396 [details] Updated patch using adjustRepaintRect() View in context: https://bugs.webkit.org/attachment.cgi?id=78396&action=review > Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:220 > + IntRect indicatorRect(rect.x(), rect.y() + ((rect.height() - indicatorSize) / 2), indicatorSize, indicatorSize); It seems like ((rect.height() - indicatorSize) / 2) is dead code, so it should probably be removed.
Carlos Garcia Campos
Comment 5 2011-01-10 09:33:30 PST
Created attachment 78403 [details] Update patch according to review You are right that code is indeed useless. Thanks!
WebKit Review Bot
Comment 6 2011-01-10 09:36:44 PST
Attachment 78403 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/gtk/RenderThemeGtk3.cpp']" exit_code: 1 Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:124: Use 0 instead of NULL. [readability/null] [5] Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:204: Use 0 instead of NULL. [readability/null] [5] Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:225: Use 0 instead of NULL. [readability/null] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Martin Robinson
Comment 7 2011-01-10 09:47:26 PST
Comment on attachment 78403 [details] Update patch according to review \m/ One more to go.
Carlos Garcia Campos
Comment 8 2011-01-10 11:10:37 PST
Committed r75391: <http://trac.webkit.org/changeset/75391>
Note You need to log in before you can comment on or make changes to this bug.