Bug 51804 – Make EFL a core builder

• Status: RESOLVED
• Resolution: LATER
• Component: Tools / Tests

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 77780 [details]
Patch

[Adam Barth]

Comment on attachment 77780 [details]
Patch

Thanks.  I'm surprised you don't need to update the webkitpy unit tests.  Did you try running ./Tools/Scripts/test-webkitpy ?

[Patrick R. Gansterer]

(In reply to comment #2)
> (From update of attachment 77780 [details])
> Thanks.  I'm surprised you don't need to update the webkitpy unit tests.  Did you try running ./Tools/Scripts/test-webkitpy ?
Not all build slaves are in the unit tests (e.g. WinCairo too). So i don't find sth to change.

[Adam Barth]

Ok.  We might need to update the test to cover all the builders we have now.

[WebKit Commit Bot]

Comment on attachment 77780 [details]
Patch

Rejecting attachment 77780 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:
   self.assertEquals(buildbot.core_builder_names_regexps, name_regexps)
AssertionError: ['SnowLeopard.*Build', 'SnowLeopard.*\\(Test', 'Leopard', 'Tiger', 'Windows.*Build', 'EFL', 'GTK.*32', 'GTK.*64.*Debug', 'Qt', 'Chromium.*Release$'] != ['SnowLeopard.*Build', 'SnowLeopard.*\\(Test', 'Leopard', 'Tiger', 'Windows.*Build', 'GTK.*32', 'GTK.*64.*Debug', 'Qt', 'Chromium.*Release$']

----------------------------------------------------------------------
Ran 766 tests in 19.645s

FAILED (failures=1)

Full output: http://queues.webkit.org/results/7251392

[Patrick R. Gansterer]

Created attachment 77781 [details]
Patch

(In reply to comment #2)
> (From update of attachment 77780 [details])
> Did you try running ./Tools/Scripts/test-webkitpy ?
Now it works on my machine.

[WebKit Commit Bot]

Comment on attachment 77781 [details]
Patch

Clearing flags on attachment: 77781

Committed r74881: <http://trac.webkit.org/changeset/74881>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 77781 [details]:

fast/images/load-img-with-empty-src.html bug 50855 (author: [e-mail])
The commit-queue is continuing to process your patch.

[Alexey Proskuryakov]

Shouldn't making a builder "core" require webkit-dev discussion? This is a burden on all WebKit developers.

[Adam Barth]

(In reply to comment #10)
> Shouldn't making a builder "core" require webkit-dev discussion? This is a burden on all WebKit developers.

Historically we haven't.  Being a core builder is just an empirical property.  If the builder is consistently green, it's a core builder.  According to the buildbot logs, the EFL builder has been pretty consistently green.  If it stops being green consistently, we can remove it from the list of core builders.

[Eric Seidel (no email)]

The EFL builder is now core, but has been read for at least the last day due to some sort of compile failure.

[Patrick R. Gansterer]

(In reply to comment #12)
> The EFL builder is now core, but has been read for at least the last day due to some sort of compile failure.

There's some problem with the machine. The port is ok at the moment and compiles on my machine. I didn't see one of the slave admin in IRC since it's down. :-(

[Eric Seidel (no email)]

Thanks.

[Adam Barth]

This bot has been red for a while.  Looks like we might have acted too soon.  I didn't realize that paroga owns the WinCE bots and not the EFL bot.

[Adam Barth]

Revert the change in https://bugs.webkit.org/show_bug.cgi?id=52357