Bug 51803 – REGRESSION(r74847): "Preprocessor guards should be in header files" (Requested by ap on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/74847 broke the build:
"Preprocessor guards should be in header files" (Requested by ap on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 77779 [details]
ROLLOUT of r74847

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

[WebKit Commit Bot]

Comment on attachment 77779 [details]
ROLLOUT of r74847

Rejecting attachment 77779 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 77779]" exit_code: 1
Last 500 characters of output:
sions/2.6/lib/python2.6/urllib2.py", line 361, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_http.py", line 756, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_http.py", line 706, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 8] nodename nor servname provided, or not known>

Full output: http://queues.webkit.org/results/7261357

[Alexey Proskuryakov]

Comment on attachment 77779 [details]
ROLLOUT of r74847

Trying again...

[WebKit Commit Bot]

Comment on attachment 77779 [details]
ROLLOUT of r74847

Rejecting attachment 77779 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-attachment', '--no-update', '--non-interactive', 77779]" exit_code: 2
Last 500 characters of output:
e/workers/WorkerContext.cpp.rej
patching file WebCore/workers/WorkerMessagingProxy.cpp
Hunk #1 FAILED at 38.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/workers/WorkerMessagingProxy.cpp.rej
patching file WebCore/xml/XMLHttpRequest.cpp
Hunk #1 FAILED at 35.
Hunk #2 FAILED at 53.
Hunk #3 FAILED at 355.
3 out of 3 hunks FAILED -- saving rejects to file WebCore/xml/XMLHttpRequest.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7240304

[WebKit Review Bot]

http://trac.webkit.org/changeset/74877 might have broken Leopard Intel Debug (Tests)

[Alexey Proskuryakov]

> Rejecting attachment 77779 [details] from commit-queue.

This has been landed by commit queue in r74877. Did two queue instances try to process this at once, again?

[Adam Barth]

> Did two queue instances try to process this at once, again?

Yes.  Looks like we're having some locking trouble.

[Adam Barth]

https://bugs.webkit.org/show_bug.cgi?id=51805