RESOLVED FIXED 51800
Remove EventQueue.cpp from the wincairo build as it is already included in DOMAllinOne.cpp. Also WKImageCG. 
https://bugs.webkit.org/show_bug.cgi?id=51800
Summary Remove EventQueue.cpp from the wincairo build as it is already included in DO...
Carl Lobo
Reported 2011-01-02 01:17:38 PST
Remove EventQueue.cpp from the wincairo build as it is already included in DOMAllinOne.cpp
Attachments
Patch (1.71 KB, patch)
2011-01-02 02:04 PST, Carl Lobo 		no flags
DetailsFormatted DiffDiff
Patch (2.58 KB, patch)
2011-01-02 02:40 PST, Carl Lobo 		no flags
DetailsFormatted DiffDiff
Patch (3.02 KB, patch)
2011-01-04 21:22 PST, Carl Lobo 		no flags
DetailsFormatted DiffDiff
Patch (3.18 KB, patch)
2011-01-04 23:10 PST, Carl Lobo 		eric: review-
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Carl Lobo
Comment 1 2011-01-02 02:04:46 PST
Created attachment 77774 [details] Patch
Carl Lobo
Comment 2 2011-01-02 02:40:06 PST
Created attachment 77775 [details] Patch
Eric Seidel (no email)
Comment 3 2011-01-03 23:43:22 PST
Comment on attachment 77775 [details] Patch rs=me.
WebKit Commit Bot
Comment 4 2011-01-03 23:45:18 PST
Comment on attachment 77775 [details] Patch Rejecting attachment 77775 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-attachment', '--no-update', '--non-interactive', 77775]" exit_code: 2 Last 500 characters of output: #1 succeeded at 1 with fuzz 3. patching file WebCore/WebCore.vcproj/WebCore.vcproj Hunk #1 FAILED at 43645. Hunk #2 FAILED at 43673. 2 out of 2 hunks FAILED -- saving rejects to file WebCore/WebCore.vcproj/WebCore.vcproj.rej patching file WebKit2/win/WebKit2.vcproj Hunk #1 FAILED at 951. 1 out of 1 hunk FAILED -- saving rejects to file WebKit2/win/WebKit2.vcproj.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7306384
Carl Lobo
Comment 5 2011-01-04 21:22:27 PST
Created attachment 77968 [details] Patch
Eric Seidel (no email)
Comment 6 2011-01-04 22:22:32 PST
Comment on attachment 77968 [details] Patch I'm confused by all the whitespace changes?
Carl Lobo
Comment 7 2011-01-04 22:25:09 PST
The file got generated by the IDE. I'll have to remove them by hand I guess.
Carl Lobo
Comment 8 2011-01-04 23:10:32 PST
Created attachment 77972 [details] Patch
Eric Seidel (no email)
Comment 9 2011-01-06 12:31:21 PST
Comment on attachment 77972 [details] Patch I'm still confused by the whitespace changes. Are you suggesting that the existing checked-in file disagrees with what an IDE would generate? Seems we should be checking-in the IDE version?
Carl Lobo
Comment 10 2011-01-06 18:49:29 PST
I'm using VCExpress which may differ from Visual Studio. The checked in file is good enough. Fixing the whitespace diffs would anyway ensure that nothing else sneaks in.
WebKit Commit Bot
Comment 11 2011-01-06 20:29:24 PST
Comment on attachment 77972 [details] Patch Rejecting attachment 77972 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf-cq', 'apply-attachment', '--no-update', '--non-interactive', 77972]" exit_code: 2 Last 500 characters of output: /Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/WebCore.vcproj/WebCore.vcproj Hunk #1 FAILED at 43701. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/WebCore.vcproj/WebCore.vcproj.rej Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7267447
Eric Seidel (no email)
Comment 12 2011-01-06 20:32:45 PST
Maybe one of the people who actually work on windows could help you here.
Carl Lobo
Comment 13 2011-01-06 21:25:43 PST
I guess the best way would be just to ignore the file EventQueue.cpp for all configurations in this case - it is already excluded for the Apple configurations.
Eric Seidel (no email)
Comment 14 2011-06-18 19:55:07 PDT
Comment on attachment 77972 [details] Patch Needs updated patch.
Brent Fulgham
Comment 15 2012-01-12 10:32:36 PST
The EventQueue.cpp exclusion change was committed by someone else in another bug. We can close this issue.
Note You need to log in before you can comment on or make changes to this bug.