Some renaming and refactoring of form element code
Created attachment 77733 [details] Patch
Comment on attachment 77733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77733&action=review > WebCore/html/HTMLFormElement.cpp:629 > + HTMLFormControlElement* aliasElement = elementForAlias(name); > + if (aliasElement) { I’d move the definition of aliasElement into the if statement, since it doesn’t seem to be used outside of it.
Comment on attachment 77733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77733&action=review A nice improvement. Thanks. > WebCore/html/HTMLFormElement.cpp:667 > +bool HTMLFormElement::autoComplete() const > +{ > + return !equalIgnoringCase(fastGetAttribute(autocompleteAttr), "off"); > +} I take you don't think the caching is worthwhile. Probably true. > WebCore/html/HTMLSelectElement.cpp:197 > + listItems()[listIndex]->remove(ec); Woah, that works? Cool.
Comment on attachment 77733 [details] Patch Actually, that variable is used outside the if.
Comment on attachment 77733 [details] Patch Clearing flags on attachment: 77733 Committed r74841: <http://trac.webkit.org/changeset/74841>
All reviewed patches have been landed. Closing bug.