Bug 51781 - long long should not be en- and decoded as int64_t
Summary: long long should not be en- and decoded as int64_t
Status: RESOLVED DUPLICATE of bug 51754
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-12-31 09:40 PST by Balazs Kelemen
Modified: 2011-01-02 16:37 PST (History)
7 users (show)

See Also:

compile error - gcc output (3.42 KB, text/x-log)
2010-12-31 09:42 PST, Balazs Kelemen
no flags Details
Patch (5.94 KB, patch)
2010-12-31 09:49 PST, Balazs Kelemen
no flags Details | Formatted Diff | Diff
Patch (5.51 KB, patch)
2011-01-01 22:41 PST, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2010-12-31 09:40:44 PST
On 64bit linux with gcc 4.5.1 long long and int64_t is not the same type.
This cause build errors in the decoder and encoder classes.
The easiest way to solve this in once for all seems to be introducing templates for en- and decoding
unsigned long long and long long.
Comment 1 Balazs Kelemen 2010-12-31 09:42:39 PST
Created attachment 77725 [details]
compile error - gcc output
Comment 2 Balazs Kelemen 2010-12-31 09:49:45 PST
Created attachment 77726 [details]
Comment 3 Build Bot 2010-12-31 10:37:03 PST
Attachment 77726 [details] did not build on win:
Build output: http://queues.webkit.org/results/7305292
Comment 4 WebKit Review Bot 2010-12-31 10:48:57 PST
Attachment 77726 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7212314
Comment 5 Balazs Kelemen 2010-12-31 11:20:14 PST
Oops. Now the new functions redefine the existing ones on 32 bit. The problem
has been inverted. Need to find a trick to solving this.
Comment 6 Darin Adler 2010-12-31 11:46:45 PST
Comment on attachment 77726 [details]

No good. This will break the build on any platform where int64_t and long long are the same type.

We can't mix built-in types with typedefs easily.
Comment 7 Csaba Osztrogonác 2011-01-01 05:06:54 PST
After this bug is fixed I will enable WK2 build on one of our 64 bit buildbot not to break the 64 bit build again.
Comment 8 Early Warning System Bot 2011-01-01 05:13:08 PST
Attachment 77726 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7223307
Comment 9 Balazs Kelemen 2011-01-01 22:41:11 PST
Created attachment 77769 [details]
Comment 10 Benjamin Poulain 2011-01-02 09:57:19 PST
I also had a bug for the problem: 51754, I mark this bug as duplicate so we discuss in one place.
We have 3 patches for the same problem, we should be able to find a solution :)

*** This bug has been marked as a duplicate of bug 51754 ***
Comment 11 Csaba Osztrogonác 2011-01-02 16:37:55 PST
Comment on attachment 77769 [details]

remove r? from obsolete patch