Bug 51778 - Detect direction of stack growth at runtime
Summary: Detect direction of stack growth at runtime
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-31 07:40 PST by Patrick R. Gansterer
Modified: 2011-01-06 13:14 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2010-12-31 07:45 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (1.82 KB, patch)
2010-12-31 10:09 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Alternative Patch (1.41 KB, patch)
2011-01-02 16:08 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Alternative Patch (Minimal Version) (1.12 KB, patch)
2011-01-02 16:19 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-12-31 07:40:49 PST 
see patch
Comment 1 Patrick R. Gansterer 2010-12-31 07:45:35 PST 
Created attachment 77719 [details]
Patch
Comment 2 WebKit Review Bot 2010-12-31 07:46:53 PST 
Attachment 77719 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'JavaScriptCore/ChangeLog', u'JavaScriptCore/wtf/StackBounds.cpp', u'JavaScriptCore/wtf/StackBounds.h']" exit_code: 1
JavaScriptCore/wtf/StackBounds.cpp:78:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 7 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2010-12-31 09:32:29 PST 
Comment on attachment 77719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77719&action=review

> JavaScriptCore/wtf/StackBounds.h:89
> +        static bool result = detectGrowingDownward(&dummy);

result could have had a better name.  Like  growsDownward, etc.
Comment 4 Patrick R. Gansterer 2010-12-31 10:09:44 PST 
Created attachment 77727 [details]
Patch
Comment 5 Patrick R. Gansterer 2011-01-02 15:58:13 PST 
Can review this one too? It's required by bug 26276.
Comment 6 Patrick R. Gansterer 2011-01-02 16:08:33 PST 
Created attachment 77783 [details]
Alternative Patch

If the change in isGrowingDownward isn't cool we can omit it.
This is an alternative patch without this change.
Comment 7 Patrick R. Gansterer 2011-01-02 16:19:57 PST 
Created attachment 77784 [details]
Alternative Patch (Minimal Version)

That's the minimal version required for WinCE
Comment 8 WebKit Review Bot 2011-01-02 16:21:41 PST 
Attachment 77784 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/wtf/StackBounds.cpp']" exit_code: 1
Source/JavaScriptCore/wtf/StackBounds.cpp:78:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 7 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Early Warning System Bot 2011-01-02 16:42:32 PST 
Attachment 77784 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7241334
Comment 10 WebKit Review Bot 2011-01-02 18:17:38 PST 
Attachment 77784 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7273334
Comment 11 Patrick R. Gansterer 2011-01-06 13:13:11 PST 
See r75180: <http://trac.webkit.org/changeset/75180>