Bug 51778 – Detect direction of stack growth at runtime

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 77719 [details]
Patch

[WebKit Review Bot]

Attachment 77719 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'JavaScriptCore/ChangeLog', u'JavaScriptCore/wtf/StackBounds.cpp', u'JavaScriptCore/wtf/StackBounds.h']" exit_code: 1
JavaScriptCore/wtf/StackBounds.cpp:78:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 7 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Seidel (no email)]

Comment on attachment 77719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77719&action=review

> JavaScriptCore/wtf/StackBounds.h:89
> +        static bool result = detectGrowingDownward(&dummy);

result could have had a better name.  Like  growsDownward, etc.

[Patrick R. Gansterer]

Created attachment 77727 [details]
Patch

[Patrick R. Gansterer]

Can review this one too? It's required by bug 26276.

[Patrick R. Gansterer]

Created attachment 77783 [details]
Alternative Patch

If the change in isGrowingDownward isn't cool we can omit it.
This is an alternative patch without this change.

[Patrick R. Gansterer]

Created attachment 77784 [details]
Alternative Patch (Minimal Version)

That's the minimal version required for WinCE

[WebKit Review Bot]

Attachment 77784 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/wtf/StackBounds.cpp']" exit_code: 1
Source/JavaScriptCore/wtf/StackBounds.cpp:78:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 7 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Attachment 77784 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7241334

[WebKit Review Bot]

Attachment 77784 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7273334

[Patrick R. Gansterer]

See r75180: <http://trac.webkit.org/changeset/75180>