Bug 51776 - Web Inspector: make properties on Array's prototype non-enumerable
Summary: Web Inspector: make properties on Array's prototype non-enumerable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-31 05:26 PST by Pavel Podivilov
Modified: 2011-01-10 06:40 PST (History)
11 users (show)

See Also:

Attachments
Patch. (1.47 KB, patch)
2010-12-31 05:27 PST, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2010-12-31 05:26:19 PST 
Web Inspector: make properties on Array's prototype non-enumerable
Comment 1 Pavel Podivilov 2010-12-31 05:27:23 PST 
Created attachment 77717 [details]
Patch.
Comment 2 Eric Seidel (no email) 2010-12-31 09:31:05 PST 
Comment on attachment 77717 [details]
Patch.

How do we test this?  What's the purpose of this change?
Comment 3 Pavel Feldman 2011-01-10 04:46:45 PST 
(In reply to comment #2)
> (From update of attachment 77717 [details])
> How do we test this?  What's the purpose of this change?

Hey. This is a trivial change to the inspector's utility Array extension. It just makes functions on array prototype non-enumerable. It does not affect web-facing functionality. I would test it using jsunit or similar in inspector context, but we don't have such harness yet.
Comment 4 WebKit Commit Bot 2011-01-10 06:38:30 PST 
The commit-queue encountered the following flaky tests while processing attachment 77717 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2011-01-10 06:39:59 PST 
Comment on attachment 77717 [details]
Patch.

Clearing flags on attachment: 77717

Committed r75370: <http://trac.webkit.org/changeset/75370>
Comment 6 WebKit Commit Bot 2011-01-10 06:40:07 PST 
All reviewed patches have been landed.  Closing bug.