Bug 51761 - bindings/js/JSDesktopNotificationsCustom.cpp is not included in the cmake build
Summary: bindings/js/JSDesktopNotificationsCustom.cpp is not included in the cmake build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 43906
  Show dependency tree / graph
 
Reported: 2010-12-30 12:16 PST by Benjamin Meyer
Modified: 2010-12-30 13:58 PST (History)
2 users (show)

See Also:

Attachments
proposed solution (1.81 KB, patch)
2010-12-30 12:18 PST, Benjamin Meyer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Meyer 2010-12-30 12:16:09 PST 
That file is required when NOTIFICATIONS is enabled.
Comment 1 Benjamin Meyer 2010-12-30 12:18:20 PST 
Created attachment 77694 [details]
proposed solution
Comment 2 Patrick R. Gansterer 2010-12-30 12:28:55 PST 
LGTM!
Comment 3 WebKit Commit Bot 2010-12-30 12:54:46 PST 
Comment on attachment 77694 [details]
proposed solution

Rejecting attachment 77694 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--no-update', '--non-interactive', 77694]" exit_code: 2
Last 500 characters of output:
ug.
Processing patch 77694 from bug 51761.
Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file WebCore/CMakeLists.txt
patching file WebCore/ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/ChangeLog.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7206278
Comment 4 Patrick R. Gansterer 2010-12-30 13:57:25 PST 
Comment on attachment 77694 [details]
proposed solution

Clearing flags on attachment: 77694

Manually committed r74810: <http://trac.webkit.org/changeset/74810>
Comment 5 Patrick R. Gansterer 2010-12-30 13:58:18 PST 
All reviewed patches have been landed.  Closing bug.