Bug 51758 - check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
Summary: check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2010-12-30 11:41 PST by Martin Robinson
Modified: 2010-12-30 13:46 PST (History)
0 users

See Also:


Attachments
Patch (2.65 KB, patch)
2010-12-30 12:20 PST, Martin Robinson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-12-30 11:41:50 PST
gtk_widget_style_get requies the use of NULL as a call sentinel much like in g_object_get and g_object_set.
Comment 1 Martin Robinson 2010-12-30 12:20:06 PST
Created attachment 77695 [details]
Patch
Comment 2 Martin Robinson 2010-12-30 12:21:21 PST
Unfortunately this patch does not remove all of the false positives from RenderThemeGtk. It seems that check-webkit-style does not always handle multi-line function calls properly.
Comment 3 Martin Robinson 2010-12-30 13:46:32 PST
Committed r74809: <http://trac.webkit.org/changeset/74809>