RESOLVED FIXED51758
check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get 
https://bugs.webkit.org/show_bug.cgi?id=51758
Summary check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
Martin Robinson
Reported 2010-12-30 11:41:50 PST
gtk_widget_style_get requies the use of NULL as a call sentinel much like in g_object_get and g_object_set.
Attachments
Patch (2.65 KB, patch)
2010-12-30 12:20 PST, Martin Robinson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-12-30 12:20:06 PST
Created attachment 77695 [details] Patch
Martin Robinson
Comment 2 2010-12-30 12:21:21 PST
Unfortunately this patch does not remove all of the false positives from RenderThemeGtk. It seems that check-webkit-style does not always handle multi-line function calls properly.
Martin Robinson
Comment 3 2010-12-30 13:46:32 PST
Committed r74809: <http://trac.webkit.org/changeset/74809>
Note You need to log in before you can comment on or make changes to this bug.