Bug 51756 - CMAKE doesn't build plugins/PluginDataNone.cpp when ENABLE_NETSCAPE_PLUGIN_API is OFF
Summary: CMAKE doesn't build plugins/PluginDataNone.cpp when ENABLE_NETSCAPE_PLUGIN_AP...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-30 11:25 PST by Benjamin Meyer
Modified: 2010-12-30 13:02 PST (History)
1 user (show)

See Also:

Attachments
proposed solution (1005 bytes, patch)
2010-12-30 11:29 PST, Benjamin Meyer 		no flags Details | Formatted Diff | Diff
Same as before, but with a populated ChangeLog file (1.64 KB, patch)
2010-12-30 11:31 PST, Benjamin Meyer 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Meyer 2010-12-30 11:25:55 PST 
When ENABLE_NETSCAPE_PLUGIN_API is OFF the cmake build system was not including plugins/PluginDataNone.cpp which goes with plugins/PluginPackageNone.cpp and plugins/PluginViewNone.cpp.
Comment 1 Benjamin Meyer 2010-12-30 11:29:01 PST 
Created attachment 77690 [details]
proposed solution
Comment 2 Benjamin Meyer 2010-12-30 11:31:09 PST 
Created attachment 77692 [details]
Same as before, but with a populated ChangeLog file
Comment 3 Patrick R. Gansterer 2010-12-30 12:43:29 PST 
View in context: https://bugs.webkit.org/attachment.cgi?id=77692&action=review

> WebCore/CMakeLists.txt:1719
> +        plugins/PluginDataNone.cpp

r-: you need to add this in a port specific file (like EFL), becuase windows never uses PluginDataNone.
see http://trac.webkit.org/browser/trunk/WebCore/CMakeListsWinCE.txt#L116
Comment 4 Benjamin Meyer 2010-12-30 13:02:15 PST 
Following Patrick's suggestion I have modified the port cmake file and am marking this as resolved.