RESOLVED FIXED 51753
Web Inspector: move delayed search implementation to SourceFrame 
https://bugs.webkit.org/show_bug.cgi?id=51753
Summary Web Inspector: move delayed search implementation to SourceFrame
Pavel Podivilov
Reported 2010-12-30 08:53:56 PST
SourceFrame manages lazy initialization itself, so delayed searches should also be managed by SourceFrame.
Attachments
Patch. (5.41 KB, patch)
2010-12-30 08:54 PST, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2010-12-30 08:54:55 PST
Created attachment 77682 [details] Patch.
Pavel Feldman
Comment 2 2010-12-31 03:42:21 PST
Comment on attachment 77682 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=77682&action=review > WebCore/ChangeLog:5 > + Web Inspector: move delayed search implementation to SourceFrame. I think search support should either be implemented in SourceView or SourceFrame. I see no reason for having it split between the two. I'm fine with both: having it implemented in SourceFrame or in SourceView.
Pavel Feldman
Comment 3 2010-12-31 04:20:23 PST
Comment on attachment 77682 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=77682&action=review > WebCore/inspector/front-end/SourceView.js:135 > + function didFindSearchMatches(searchResults) It seems strange that you only need this callback to manage searchResults in SourceView. Consider moving to SourceFrame instead.
Eric Seidel (no email)
Comment 4 2011-01-11 03:13:13 PST
Did this land?
Pavel Podivilov
Comment 5 2011-01-11 06:09:42 PST
Committed r75497: <http://trac.webkit.org/changeset/75497>
Note You need to log in before you can comment on or make changes to this bug.