Bug 51753 - Web Inspector: move delayed search implementation to SourceFrame
Summary: Web Inspector: move delayed search implementation to SourceFrame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-30 08:53 PST by Pavel Podivilov
Modified: 2011-01-11 06:09 PST (History)
11 users (show)

See Also:

Attachments
Patch. (5.41 KB, patch)
2010-12-30 08:54 PST, Pavel Podivilov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2010-12-30 08:53:56 PST 
SourceFrame manages lazy initialization itself, so delayed searches should also be managed by SourceFrame.
Comment 1 Pavel Podivilov 2010-12-30 08:54:55 PST 
Created attachment 77682 [details]
Patch.
Comment 2 Pavel Feldman 2010-12-31 03:42:21 PST 
Comment on attachment 77682 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=77682&action=review

> WebCore/ChangeLog:5
> +        Web Inspector: move delayed search implementation to SourceFrame.

I think search support should either be implemented in SourceView or SourceFrame. I see no reason for having it split between the two. I'm fine with both: having it implemented in SourceFrame or in SourceView.
Comment 3 Pavel Feldman 2010-12-31 04:20:23 PST 
Comment on attachment 77682 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=77682&action=review

> WebCore/inspector/front-end/SourceView.js:135
> +        function didFindSearchMatches(searchResults)

It seems strange that you only need this callback to manage searchResults in SourceView. Consider moving to SourceFrame instead.
Comment 4 Eric Seidel (no email) 2011-01-11 03:13:13 PST 
Did this land?
Comment 5 Pavel Podivilov 2011-01-11 06:09:42 PST 
Committed r75497: <http://trac.webkit.org/changeset/75497>