Bug 51751 - Web Inspector: recreate script view after live edit
Summary: Web Inspector: recreate script view after live edit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-30 08:33 PST by Pavel Podivilov
Modified: 2011-01-11 06:37 PST (History)
10 users (show)

See Also:

Attachments
Patch. (4.96 KB, patch)
2010-12-30 08:34 PST, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Patch. (5.89 KB, patch)
2010-12-30 09:03 PST, Pavel Podivilov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2010-12-30 08:33:55 PST 
Recreate script view after live edit like it is done for source views.
Comment 1 Pavel Podivilov 2010-12-30 08:34:46 PST 
Created attachment 77681 [details]
Patch.
Comment 2 Pavel Podivilov 2010-12-30 09:03:25 PST 
Created attachment 77684 [details]
Patch.
Comment 3 Pavel Feldman 2011-01-11 04:39:14 PST 
Comment on attachment 77684 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=77684&action=review

> WebCore/inspector/front-end/ScriptsPanel.js:316
> +                    script.resource.setContent(newBodyOrErrorMessage, revertEditingCallback);

In the future, we'd like to edit inline script of say HTML resources. As a result, committing snippet content as resource content will become wrong.
Comment 4 Pavel Podivilov 2011-01-11 06:37:51 PST 
Committed r75500: <http://trac.webkit.org/changeset/75500>