RESOLVED WONTFIX51746
Web Inspector: get rid of non-protocol "frontendLoaded" command, make it a part of the protocol. 
https://bugs.webkit.org/show_bug.cgi?id=51746
Summary Web Inspector: get rid of non-protocol "frontendLoaded" command, make it a pa...
Pavel Feldman
Reported 2010-12-30 05:36:56 PST
We need to further refactor injected scripts initialization, this change only converts frontLoaded event into a protocol one.
Attachments
[PATCH] Proposed change. (22.49 KB, patch)
2010-12-30 06:21 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-12-30 06:21:20 PST
Created attachment 77678 [details] [PATCH] Proposed change.
Ilya Tikhonovsky
Comment 2 2010-12-30 06:42:30 PST
Comment on attachment 77678 [details] [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=77678&action=review > WebCore/inspector/Inspector.idl:40 > + [domain=Inspector] void frontendLoaded(in String scriptSource); it is not clear from the parameter's name what it is. Please use injectedScript as it is in InspectorController. I'm not sure that frontendLoaded is a good name. What do you think about frontendReady.
WebKit Review Bot
Comment 3 2010-12-30 06:45:14 PST
Attachment 77678 [details] did not build on mac: Build output: http://queues.webkit.org/results/7313278
Build Bot
Comment 4 2010-12-30 07:46:45 PST
Attachment 77678 [details] did not build on win: Build output: http://queues.webkit.org/results/7319236
Early Warning System Bot
Comment 5 2011-01-01 03:44:20 PST
Attachment 77678 [details] did not build on qt: Build output: http://queues.webkit.org/results/7261327
Note You need to log in before you can comment on or make changes to this bug.