Bug 51745 - Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox.
Summary: Web Inspector: breakpoint is not disabled when clicking on breakpoints sideba...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-30 05:36 PST by Pavel Podivilov
Modified: 2010-12-30 07:33 PST (History)
10 users (show)

See Also:


Attachments
Patch. (1.18 KB, patch)
2010-12-30 05:37 PST, Pavel Podivilov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2010-12-30 05:36:20 PST
Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox.
Comment 1 Pavel Podivilov 2010-12-30 05:37:11 PST
Created attachment 77675 [details]
Patch.
Comment 2 Pavel Feldman 2010-12-30 05:59:07 PST
Comment on attachment 77675 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=77675&action=review

> WebCore/inspector/front-end/Breakpoint.js:55
> +        this.remove();

It would be great if breakpoint had two states: "resolved" and "unresolved". In that case, setting enabled to false would simply make it unresolved unless backend confirms disabling.
Comment 3 Pavel Podivilov 2010-12-30 07:33:32 PST
Committed r74798: <http://trac.webkit.org/changeset/74798>