Bug 51742 - Add DeviceOrientationEvent.absolute
Summary: Add DeviceOrientationEvent.absolute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Steve Block
URL: http://dev.w3.org/geo/api/spec-source...
Keywords:
Depends on:
Blocks: 30335
  Show dependency treegraph
 
Reported: 2010-12-30 04:24 PST by Steve Block
Modified: 2012-03-06 14:49 PST (History)
7 users (show)

See Also:


Attachments
Patch (15.93 KB, patch)
2012-01-12 18:23 PST, Xinchao He
no flags Details | Formatted Diff | Diff
Rebase the patch, since it's conflicted with the latest update. (16.13 KB, patch)
2012-01-13 08:01 PST, Xinchao He
no flags Details | Formatted Diff | Diff
Patch for passing commit bot (16.10 KB, patch)
2012-01-13 19:00 PST, Xinchao He
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-12-30 04:24:41 PST
This property indicates whether the angle data in the event is absolute, and was recently added to the spec
Comment 1 Xinchao He 2012-01-12 18:23:39 PST
Created attachment 122356 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-12 18:25:28 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 3 Darin Fisher (:fishd, Google) 2012-01-12 21:44:44 PST
Comment on attachment 122356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122356&action=review

> Source/WebKit/chromium/public/WebDeviceOrientation.h:38
> +    WebDeviceOrientation(bool canProvideAlpha, double alpha, bool canProvideBeta, double beta, bool canProvideGamma, double gamma, bool canProvideAbsolute = false, bool absolute = false)

Do you intend to make a corresponding change in the Chromium repository?  If so, would you
consider making these parameters non-optional after those changes are complete?
Comment 4 Xinchao He 2012-01-12 22:22:11 PST
(In reply to comment #3)
> (From update of attachment 122356 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=122356&action=review
> 
> > Source/WebKit/chromium/public/WebDeviceOrientation.h:38
> > +    WebDeviceOrientation(bool canProvideAlpha, double alpha, bool canProvideBeta, double beta, bool canProvideGamma, double gamma, bool canProvideAbsolute = false, bool absolute = false)
> 
> Do you intend to make a corresponding change in the Chromium repository?  If so, would you
> consider making these parameters non-optional after those changes are complete?

Yes, I'm also doing corresponding on Chromium repository, and will upstream the patch. The parameters will be changed to non-optional ones when the bug is fixed in WebKit and Chromium.
Comment 5 Xinchao He 2012-01-13 08:01:40 PST
Created attachment 122430 [details]
Rebase the patch, since it's conflicted with the latest update.
Comment 6 Steve Block 2012-01-13 08:50:16 PST
Comment on attachment 122430 [details]
Rebase the patch, since it's conflicted with the latest update.

lgtm
Comment 7 WebKit Review Bot 2012-01-13 11:15:56 PST
Comment on attachment 122430 [details]
Rebase the patch, since it's conflicted with the latest update.

Rejecting attachment 122430 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10339 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 10339.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11157693
Comment 8 Xinchao He 2012-01-13 19:00:24 PST
Created attachment 122530 [details]
Patch for passing commit bot
Comment 9 WebKit Review Bot 2012-01-15 23:33:47 PST
Comment on attachment 122530 [details]
Patch for passing commit bot

Clearing flags on attachment: 122530

Committed r105036: <http://trac.webkit.org/changeset/105036>
Comment 10 WebKit Review Bot 2012-01-15 23:33:52 PST
All reviewed patches have been landed.  Closing bug.