Bug 51742 – Add DeviceOrientationEvent.absolute

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Steve Block]

This property indicates whether the angle data in the event is absolute, and was recently added to the spec

[Xinchao He]

Created attachment 122356 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Darin Fisher (:fishd, Google)]

Comment on attachment 122356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122356&action=review

> Source/WebKit/chromium/public/WebDeviceOrientation.h:38
> +    WebDeviceOrientation(bool canProvideAlpha, double alpha, bool canProvideBeta, double beta, bool canProvideGamma, double gamma, bool canProvideAbsolute = false, bool absolute = false)

Do you intend to make a corresponding change in the Chromium repository?  If so, would you
consider making these parameters non-optional after those changes are complete?

[Xinchao He]

(In reply to comment #3)
> (From update of attachment 122356 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=122356&action=review
> 
> > Source/WebKit/chromium/public/WebDeviceOrientation.h:38
> > +    WebDeviceOrientation(bool canProvideAlpha, double alpha, bool canProvideBeta, double beta, bool canProvideGamma, double gamma, bool canProvideAbsolute = false, bool absolute = false)
> 
> Do you intend to make a corresponding change in the Chromium repository?  If so, would you
> consider making these parameters non-optional after those changes are complete?

Yes, I'm also doing corresponding on Chromium repository, and will upstream the patch. The parameters will be changed to non-optional ones when the bug is fixed in WebKit and Chromium.

[Xinchao He]

Created attachment 122430 [details]
Rebase the patch, since it's conflicted with the latest update.

[Steve Block]

Comment on attachment 122430 [details]
Rebase the patch, since it's conflicted with the latest update.

lgtm

[WebKit Review Bot]

Comment on attachment 122430 [details]
Rebase the patch, since it's conflicted with the latest update.

Rejecting attachment 122430 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10339 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 10339.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11157693

[Xinchao He]

Created attachment 122530 [details]
Patch for passing commit bot

[WebKit Review Bot]

Comment on attachment 122530 [details]
Patch for passing commit bot

Clearing flags on attachment: 122530

Committed r105036: <http://trac.webkit.org/changeset/105036>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.