Bug 51740 - Enable JSC Rich Source Info for Android even when Inspector and Debugger are disabled
Summary: Enable JSC Rich Source Info for Android even when Inspector and Debugger are ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-30 03:08 PST by Steve Block
Modified: 2010-12-30 12:53 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2010-12-30 03:18 PST, Steve Block 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-12-30 03:08:57 PST 
Android does not enable either the Inspector or Debugger. It does however use rich source info (eg line numbers for exceptions) 

http://trac.webkit.org/changeset/72360 changed JSC to guard the exception-generation code behind enable flags. As a result, rich source info was disabled for Android.

We should re-enable rich source info for Android. This can be done in JSDOMWindowBase::supportsRichSourceInfo(), which encapsulates such policy decisions.
Comment 1 Steve Block 2010-12-30 03:18:36 PST 
Created attachment 77670 [details]
Patch
Comment 2 WebKit Commit Bot 2010-12-30 12:53:46 PST 
Comment on attachment 77670 [details]
Patch

Clearing flags on attachment: 77670

Committed r74806: <http://trac.webkit.org/changeset/74806>
Comment 3 WebKit Commit Bot 2010-12-30 12:53:53 PST 
All reviewed patches have been landed.  Closing bug.