RESOLVED FIXED Bug 51739
[CMake] Fix the usage of SOURCE_GROUP 
https://bugs.webkit.org/show_bug.cgi?id=51739
Summary [CMake] Fix the usage of SOURCE_GROUP
Patrick R. Gansterer
Reported 2010-12-30 03:02:56 PST
see patch
Attachments
Patch (5.16 KB, patch)
2010-12-30 03:06 PST, Patrick R. Gansterer 		kling: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch (5.15 KB, patch)
2011-01-05 06:46 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-12-30 03:06:03 PST
Created attachment 77668 [details] Patch
Andreas Kling
Comment 2 2011-01-05 06:39:52 PST
Comment on attachment 77668 [details] Patch rs=me
WebKit Commit Bot
Comment 3 2011-01-05 06:41:14 PST
Comment on attachment 77668 [details] Patch Rejecting attachment 77668 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-attachment', '--no-update', '--non-interactive', 77668]" exit_code: 2 Last 500 characters of output: --- Sources/cmake/WebKitMacros.cmake |+++ Sources/cmake/WebKitMacros.cmake -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored patching file WebCore/CMakeLists.txt Hunk #1 FAILED at 2215. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/CMakeLists.txt.rej patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7210426
Patrick R. Gansterer
Comment 4 2011-01-05 06:46:46 PST
Created attachment 77999 [details] Patch Sources -> Source
WebKit Commit Bot
Comment 5 2011-01-05 06:52:32 PST
Comment on attachment 77999 [details] Patch Rejecting attachment 77999 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf-cq', 'apply-attachment', '--no-update', '--non-interactive', 77999]" exit_code: 2 Last 500 characters of output: eded at 1 with fuzz 3. patching file Source/JavaScriptCore/CMakeLists.txt patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/cmake/WebKitMacros.cmake patching file WebCore/CMakeLists.txt Hunk #1 FAILED at 2215. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/CMakeLists.txt.rej patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7338329
Patrick R. Gansterer
Comment 6 2011-01-05 14:40:46 PST
Comment on attachment 77999 [details] Patch Clearing flags on attachment: 77999 Manually committed r75069: <http://trac.webkit.org/changeset/75069>
Patrick R. Gansterer
Comment 7 2011-01-05 14:41:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.