Bug 51722 - JSDataViewCustom.cpp gives the fastcall calling convention to functions called via C++
Summary: JSDataViewCustom.cpp gives the fastcall calling convention to functions calle...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 31517
  Show dependency tree / graph
 
Reported: 2010-12-29 13:53 PST by Martin Robinson
Modified: 2010-12-29 14:21 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.97 KB, patch)
2010-12-29 14:11 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-12-29 13:53:45 PST 
JSDataView methods like JSDataView::getInt8 are labeled with JSC_HOST_CALL, which gives them the fastcall calling convention. This leads to runtime errors, because these methods are called from C++ code in the auto-generated JSDataView.cpp. This was observed when running fast/canvas/webgl/data-view-test.html on the upcoming GTK+ WebGL implementation.
Comment 1 Martin Robinson 2010-12-29 14:11:33 PST 
Created attachment 77643 [details]
Patch
Comment 2 Martin Robinson 2010-12-29 14:21:12 PST 
Committed r74760: <http://trac.webkit.org/changeset/74760>