Bug 51721 – fast/encoding/parser-tests.html is slow on debug builds

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Mihai Parparita]

fast/encoding/parser-tests.html (added by http://trac.webkit.org/changeset/73756) takes 25 seconds+ to run with debug builds:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fencoding%2Fparser-tests.html

This makes it much more likely to time out or flake if the test bot is under load. Since it looks like it's running multiple test cases, breaking up those into chunks may be a way to speed things up.

[Adam Barth]

Yeah, it should be easy to break unto a bunch of smaller tests.

[Jenn Braithwaite]

Created attachment 77922 [details]
patch

Broke up parser-tests.html to run 10 tests each. Every parser-tests-XX.html file is identical except for initial current and max values.

[Mihai Parparita]

Comment on attachment 77922 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77922&action=review

> LayoutTests/fast/encoding/parser-tests-10.html:20
> +  <script>

Instead of repeating the harness script for every .html file, can you move it into a .js file in resources and reference it?

Ideally it would also write out the text description (and expected failures), so that they don't have to be repeated either.

[Jenn Braithwaite]

Created attachment 77930 [details]
patch

Test suite logic moved into resources/parser-tests.js as suggested.

[Mihai Parparita]

Comment on attachment 77930 [details]
patch

Much better (unfortunately I'm not a reviewer so I can't r+ this).

[Jenn Braithwaite]

Adam, can you take a look as you reviewed the original patch?  Thanks!

[WebKit Commit Bot]

Comment on attachment 77930 [details]
patch

Clearing flags on attachment: 77930

Committed r75111: <http://trac.webkit.org/changeset/75111>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.