Bug 51712 - [Chromium] After r57004, readonly attributes that return non-constant values, leak wrappers
Summary: [Chromium] After r57004, readonly attributes that return non-constant values,...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-29 10:03 PST by Mikhail Naganov
Modified: 2013-04-11 13:01 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2010-12-29 10:03:06 PST 
In https://trac.webkit.org/changeset/57004, CodeGeneratorV8 is changed to cache wrappers for 'readonly' IDL values, using native object pointer as a hash value. That means, if different object pointer value is returned, previous wrapper will stall in the cache, creating a memory leak. For example, that happened with MemoryInfo object which is created anew on every Console::memory() call. 'readonly' doesn't mean 'constant'!

I think, this logic needs to be revised, because nothing in .idl specifies that getter value returns the same native pointer.