Bug 51691 - [GTK] GSettings warning is concealing real warnings on the build bots
: [GTK] GSettings warning is concealing real warnings on the build bots
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit Gtk
: 528+ (Nightly build)
: PC Linux
: P3 Normal
Assigned To: Nobody
: Gtk
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-28 14:49 PST by Martin Robinson
Modified: 2010-12-29 15:38 PST (History)
3 users (show)

See Also:


Attachments
Patch for this issue (1.59 KB, patch)
2010-12-28 14:50 PST, Martin Robinson
no flags Details | Formatted Diff | Diff
An alternate approach to this problem (2.44 KB, patch)
2010-12-29 08:40 PST, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-12-28 14:49:00 PST
Warnings about GSettings about very common the build bots. This ends up concealing real warnings, because there are so many tests with stderr output.

Here is the output text:
GSettings schema not found - settings will not be used or saved.
GSettings schema not found - settings will not be used or saved.
GSettings schema not found - settings will not be used or saved.
Comment 1 Martin Robinson 2010-12-28 14:50:50 PST
Created attachment 77581 [details]
Patch for this issue
Comment 2 Eric Seidel 2010-12-28 20:18:41 PST
Comment on attachment 77581 [details]
Patch for this issue

OK.  It's sad that that's the only way to disable the message.  Is that string saved anywhere in Gtk that you could compare against a variable instead of a manually typed c-string?
Comment 3 Martin Robinson 2010-12-29 08:40:01 PST
Created attachment 77621 [details]
An alternate approach to this problem
Comment 4 Martin Robinson 2010-12-29 08:44:13 PST
(In reply to comment #3)
> Created an attachment (id=77621) [details]
> An alternate approach to this problem

Here's another way to approach the issue. Instead of filtering the message in DumpRenderTree, this patch modifies WebKitGTK+ to not print the message when running in DumpRenderTree.
Comment 5 Xan Lopez 2010-12-29 14:13:33 PST
Comment on attachment 77621 [details]
An alternate approach to this problem

I prefer this one by a long shot.
Comment 6 Martin Robinson 2010-12-29 14:34:49 PST
Comment on attachment 77621 [details]
An alternate approach to this problem

Clearing flags on attachment: 77621

Committed r74762: <http://trac.webkit.org/changeset/74762>
Comment 7 Martin Robinson 2010-12-29 14:34:53 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2010-12-29 15:38:33 PST
http://trac.webkit.org/changeset/74762 might have broken Leopard Intel Debug (Tests)