Bug 51671 – <VT> and <FF> are not valid JSON whitespace characters

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Helder Correia]

Vertical Tab and Form Feed are not considered allowed white spaces by the JSON spec (section 2: JSON Grammar): http://www.ietf.org/rfc/rfc4627.txt

[Helder Correia]

Created attachment 77543 [details]
Patch

[Alexey Proskuryakov]

At least part of this was already being tracked as bug 41102.

[Eric Seidel (no email)]

Comment on attachment 77543 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77543&action=review

The fix looks fine.  But making isAllowedSpace clearer will help make this code easier to understand for future peopel hacking here.

> JavaScriptCore/runtime/LiteralParser.cpp:38
> +static inline bool isAllowedSpace(const UChar c)

Seems this name should more clearly state what type of allowed space this is.  is this a JSON Whitespace?  is this a SomeSpecificSpecNameWhitespace?  It would be best to provide a link next to this function where the list of whitespace chars are defined.  How do I validate that this is the right list when I'm looking at this code a month from now?

[Helder Correia]

Created attachment 77576 [details]
Add suggestions from comment #3 (link to JSON spec)

[Eric Seidel (no email)]

Comment on attachment 77576 [details]
Add suggestions from comment #3 (link to JSON spec)

Perfect!  Thanks!

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 77576 [details]:

http/tests/xmlhttprequest/basic-auth.html bug 51613 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 77576 [details]
Add suggestions from comment #3 (link to JSON spec)

Clearing flags on attachment: 77576

Committed r74737: <http://trac.webkit.org/changeset/74737>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.