Bug 51661 - ContextShadow should use AffineTransform instead of TransformationMatrix
Summary: ContextShadow should use AffineTransform instead of TransformationMatrix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-27 17:40 PST by Helder Correia
Modified: 2011-01-05 19:06 PST (History)
9 users (show)

See Also:

Attachments
Patch (6.33 KB, patch)
2010-12-27 17:45 PST, Helder Correia 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Helder Correia 2010-12-27 17:40:57 PST 
ContextShadow needs the CTM to make sure shadows are not affected by transformations when drawing on a canvas.  AffineTransform is sufficient in this case.
Comment 1 Helder Correia 2010-12-27 17:45:02 PST 
Created attachment 77530 [details]
Patch
Comment 2 Ariya Hidayat 2010-12-27 19:46:58 PST 
Comment on attachment 77530 [details]
Patch

LGTM. re=me
Comment 3 Ariya Hidayat 2010-12-27 20:45:02 PST 
Comment on attachment 77530 [details]
Patch

cq+
Comment 4 WebKit Commit Bot 2010-12-27 21:33:18 PST 
Comment on attachment 77530 [details]
Patch

Clearing flags on attachment: 77530

Committed r74708: <http://trac.webkit.org/changeset/74708>
Comment 5 WebKit Commit Bot 2010-12-27 21:33:24 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-12-28 07:56:41 PST 
http://trac.webkit.org/changeset/74708 might have broken Leopard Intel Debug (Tests)
Comment 7 Sam Weinig 2010-12-28 10:37:51 PST 
It seem like the function name getTransformationMatrixFromContext really should be changed as well.
Comment 8 Helder Correia 2011-01-05 19:06:57 PST 
(In reply to comment #7)
> It seem like the function name getTransformationMatrixFromContext really should be changed as well.

Just a follow-up: the function was removed in http://trac.webkit.org/changeset/74947