Bug 51655 - [Cairo] fast/canvas/canvas-save-restore-with-path.html fails with some versions of Cairo
Summary: [Cairo] fast/canvas/canvas-save-restore-with-path.html fails with some versio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2010-12-27 14:47 PST by Martin Robinson
Modified: 2010-12-27 16:48 PST (History)
6 users (show)

See Also:

Attachments
Patch for this issue (1.38 KB, patch)
2010-12-27 14:52 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-12-27 14:47:55 PST 
Due to rounding errors, fast/canvas/canvas-save-restore-with-path.html may fail with some versions of Cairo. The failure looks like this:

--- /tmp/layout-test-results/fast/canvas/canvas-save-restore-with-path-expected.txt	2010-12-27 14:41:41.237192001 -0800
+++ /tmp/layout-test-results/fast/canvas/canvas-save-restore-with-path-actual.txt	2010-12-27 14:41:41.237192001 -0800
@@ -7,7 +7,7 @@
 PASS getPixel(75,25) is [0,128,0,255]
 PASS getPixel(75,50) is [255,0,0,255]
 PASS getPixel(25,75) is [0,128,0,255]
-PASS getPixel(50,75) is [255,0,0,255]
+FAIL getPixel(50,75) should be 255,0,0,255. Was 254,1,0,255.
 PASS getPixel(75,75) is [0,128,0,255]
 PASS successfullyParsed is true
Comment 1 Martin Robinson 2010-12-27 14:52:05 PST 
Created attachment 77521 [details]
Patch for this issue
Comment 2 Martin Robinson 2010-12-27 16:17:32 PST 
Comment on attachment 77521 [details]
Patch for this issue

Clearing flags on attachment: 77521

Committed r74699: <http://trac.webkit.org/changeset/74699>
Comment 3 Martin Robinson 2010-12-27 16:17:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2010-12-27 16:48:20 PST 
http://trac.webkit.org/changeset/74699 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
fast/canvas/canvas-save-restore-with-path.html