Bug 51643 – [WINCE] Provide 3rd party directory via environment variable

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 77503 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 77503 [details]
Patch

This seems confusing.  Since we already have a ThirdParty directory in our sources.  Seems like this is a WINCE3RDPARTY directory or similar?  Also, why not spell out THRID?

[Patrick R. Gansterer]

(In reply to comment #2)
> (From update of attachment 77503 [details])
> This seems confusing.  Since we already have a ThirdParty directory in our sources.  Seems like this is a WINCE3RDPARTY directory or similar?  Also, why not spell out THRID?
IMHO it's not WinCE specific. Other (embedded) port, where you can't use the system libraries of the host, maybe need a 3rd party directory for png, jpeg, xml, ... too.
It's ok to spell out, but we should change it everywhere in the CMake files. ;-)

[Patrick R. Gansterer]

Created attachment 77840 [details]
Patch

[Darin Adler]

Comment on attachment 77840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77840&action=review

> Sources/cmake/OptionsWinCE.cmake:14
> +    IF (EXISTS $ENV{WEBKITTHRIDPARTYDIR})
> +        SET(3RDPARTY_DIR $ENV{WEBKITTHRIDPARTYDIR})

Typo: THRID

[Patrick R. Gansterer]

(In reply to comment #5)
> (From update of attachment 77840 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77840&action=review
> 
> > Sources/cmake/OptionsWinCE.cmake:14
> > +    IF (EXISTS $ENV{WEBKITTHRIDPARTYDIR})
> > +        SET(3RDPARTY_DIR $ENV{WEBKITTHRIDPARTYDIR})
> 
> Typo: THRID
Good catch!

Manually committed r74938: <http://trac.webkit.org/changeset/74938>

[WebKit Review Bot]

http://trac.webkit.org/changeset/74942 might have broken Windows Release (Build) and Windows Debug (Build)