Bug 51627 - [Qt] Support for CSS color and background-color properties on select element's dropdown list
Summary: [Qt] Support for CSS color and background-color properties on select element'...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-12-26 18:39 PST by Xianlin Han
Modified: 2011-03-27 23:35 PDT (History)
3 users (show)

See Also:

Attachments
test html file (327 bytes, text/html)
2010-12-26 19:00 PST, Xianlin Han 		no flags Details
Proposed patch (4.31 KB, patch)
2011-03-27 08:35 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xianlin Han 2010-12-26 18:39:36 PST 
Webkit Qt Need support for css color and background-color properties on select element's dropdown list。
See Bug 9846. The same appearance, but I tried under Google Chrome, this bug do not reappear. So I think Bug 9846 may fixed. But Webkit Qt still have this problem.
Comment 1 Xianlin Han 2010-12-26 19:00:24 PST 
Created attachment 77471 [details]
test html file

Add the test html file
Comment 2 Benjamin Poulain 2011-01-14 10:54:12 PST 
Please follow this to report bugs on QtWebKit: http://trac.webkit.org/wiki/QtWebKitBugs

Because you did not use the template, we did not have this bug in our list.

Good catch otherwise. Thanks for attaching a test case as well.
Comment 3 Andreas Kling 2011-03-27 08:35:20 PDT 
Created attachment 87071 [details]
Proposed patch
Comment 4 Kenneth Rohde Christiansen 2011-03-27 12:07:44 PDT 
Comment on attachment 87071 [details]
Proposed patch

Looks ok, though I wonder how useful it is supporting this
Comment 5 Andreas Kling 2011-03-27 12:12:26 PDT 
Comment on attachment 87071 [details]
Proposed patch

Clearing flags on attachment: 87071

Committed r82075: <http://trac.webkit.org/changeset/82075>
Comment 6 Andreas Kling 2011-03-27 12:12:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Laszlo Gombos 2011-03-27 23:35:45 PDT 
I think together with this change we need to increment the version in qwebkitplatformplugin.h (to 1.8).