Bug 51604 - Move JavaScriptCore to Sources
Summary: Move JavaScriptCore to Sources
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
Depends on:
Blocks: 51606
  Show dependency treegraph
Reported: 2010-12-24 23:48 PST by Adam Barth
Modified: 2011-01-03 03:14 PST (History)
11 users (show)

See Also:

Patch (51.90 KB, patch)
2010-12-24 23:53 PST, Adam Barth
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-12-24 23:48:43 PST
Move JavaScriptCore to Sources
Comment 1 Adam Barth 2010-12-24 23:53:22 PST
Created attachment 77434 [details]
Comment 2 Adam Barth 2010-12-24 23:54:37 PST
This patch doesn't actually contain the move because that would make the patch file huge.  That means this will show up red on all the EWS bots.

I'm going to hold off landing this patch until folks have plenty of warning.  I just wanted to get it uploaded so folks could look at it and let me know what I screwed up.
Comment 3 WebKit Review Bot 2010-12-25 00:08:04 PST
Attachment 77434 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7243188
Comment 4 Early Warning System Bot 2010-12-25 00:11:46 PST
Attachment 77434 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7200187
Comment 5 WebKit Review Bot 2010-12-25 00:22:14 PST
Attachment 77434 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7209207
Comment 6 Build Bot 2010-12-25 02:15:39 PST
Attachment 77434 [details] did not build on win:
Build output: http://queues.webkit.org/results/7286175
Comment 7 Eric Seidel (no email) 2010-12-26 13:28:45 PST
Comment on attachment 77434 [details]

Comment 8 Adam Barth 2011-01-01 22:23:22 PST
Comment 9 Csaba Osztrogonác 2011-01-02 08:14:43 PST
One Qt buildfix landed in http://trac.webkit.org/changeset/74869
(Robert was faster than my svn update :) )

But we need one more fix for WebKit2, because 
can't handle the Sources/JavaScriptCore directory.

I can check it 4-5 hours later. Or maybe Andras can be faster. :)
Comment 10 Adam Barth 2011-01-02 12:13:45 PST
Thanks guys.  Sorry for the hassle.
Comment 11 Csaba Osztrogonác 2011-01-03 03:14:30 PST
Qt-WK2 fix landed: http://trac.webkit.org/changeset/74873 (workaround)

[Qt] run-javascriptcore-tests fix landed: http://trac.webkit.org/changeset/74874

[Qt] BuildSlaveSupport/built-product-archive fix landed:
- http://trac.webkit.org/changeset/74875
- http://trac.webkit.org/changeset/74880

GTK fix landed: http://trac.webkit.org/changeset/74878

Trees are green again. :) Let's see the next rename bug! ;)