Bug 51598 – [Qt] [WK2] WebKit 2 does not build on mac, missing reference to RetainPtr

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

WebKit 2 does not build on Mac with default options. The problem comes from the following code:


static String formatLocalizedString(const String& format, ...)
{
#if PLATFORM(CF)
    va_list arguments;
    va_start(arguments, format);
    RetainPtr<CFStringRef> formatCFString(AdoptCF, format.createCFString());
    RetainPtr<CFStringRef> result(AdoptCF, CFStringCreateWithFormatAndArguments(0, 0, formatCFString.get(), arguments));
    va_end(arguments);
    return result.get();
#else
    notImplemented();
    return format;
#endif
}

It uses RetainPtr(), but does not include the header file. This break has been introduced by 43505.

[Benjamin Poulain]

Created attachment 77425 [details]
Patch

I apologize not to push that directly. I do not have my tools here so I figured it would be easier to use the commit queue.

[Early Warning System Bot]

Attachment 77425 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7205164

[WebKit Commit Bot]

Comment on attachment 77425 [details]
Patch

Clearing flags on attachment: 77425

Committed r74650: <http://trac.webkit.org/changeset/74650>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

I don’t think this works.

[Benjamin Poulain]

(In reply to comment #5)
> I don’t think this works.

Why?

(In reply to comment #6)
> (In reply to comment #5)
> > I don’t think this works.
> 
> Why?

Breaking Qt Linux <http://build.webkit.org/builders/Qt%20Linux%20Release/builds/25687/steps/compile-webkit/logs/stdio>

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > I don’t think this works.
> > 
> > Why?
> 
> Breaking Qt Linux <http://build.webkit.org/builders/Qt%20Linux%20Release/builds/25687/steps/compile-webkit/logs/stdio>

Fixed by Simon in <http://trac.webkit.org/projects/webkit/changeset/74654>.

[Benjamin Poulain]

(In reply to comment #8)
> > > Why?
> > 
> > Breaking Qt Linux <http://build.webkit.org/builders/Qt%20Linux%20Release/builds/25687/steps/compile-webkit/logs/stdio>
> 
> Fixed by Simon in <http://trac.webkit.org/projects/webkit/changeset/74654>.

Thanks Mitz and Simon for fixing the build on Linux.

[Csaba Osztrogonác]

(In reply to comment #9)
> > Fixed by Simon in <http://trac.webkit.org/projects/webkit/changeset/74654>.
> 
> Thanks Mitz and Simon for fixing the build on Linux.

You could have avoided this breakage if you had taken the comment of Qt-EWS seriously.