Bug 51583 - Move JavaScriptGlue into Sources
Summary: Move JavaScriptGlue into Sources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 51606
  Show dependency tree / graph
 
Reported: 2010-12-23 22:40 PST by Adam Barth
Modified: 2010-12-25 01:02 PST (History)
6 users (show)

See Also:

Attachments
Patch (539 bytes, patch)
2010-12-23 22:41 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
patch (742.31 KB, patch)
2010-12-23 23:32 PST, Adam Barth 		eric: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-12-23 22:40:04 PST 
Create Sources directory
Comment 1 Adam Barth 2010-12-23 22:41:06 PST 
Created attachment 77403 [details]
Patch
Comment 2 Adam Barth 2010-12-23 23:32:46 PST 
Created attachment 77405 [details]
patch
Comment 3 WebKit Review Bot 2010-12-24 00:27:54 PST 
Attachment 77405 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7317120
Comment 4 Adam Barth 2010-12-24 00:30:05 PST 
(In reply to comment #3)
> Attachment 77405 [details] did not build on mac:
> Build output: http://queues.webkit.org/results/7317120

It build locally more me.  I suspect the bot is confused.
Comment 5 Eric Seidel (no email) 2010-12-24 00:38:01 PST 
Or that the patch doesn't handle renames?
Comment 6 Eric Seidel (no email) 2010-12-24 00:40:08 PST 
Says it died on this chdir:
# Build, and abort if the build fails.
for my $dir (@projects) {
    chdir $dir or die;
Comment 7 Adam Barth 2010-12-24 00:44:14 PST 
> Says it died on this chdir:

Right.  I bet the directory it's chdiring into (Sources/JavaScriptGlue) doesn't exist on the bot.  It does exit locally and seems to build fine.
Comment 8 Eric Seidel (no email) 2010-12-24 00:54:49 PST 
Comment on attachment 77405 [details]
patch

rs-me
Comment 10 Adam Barth 2010-12-24 11:32:31 PST 
Thanks Darin.  I tried to edit those Makefiles but didn't do it correctly.