Bug 51575 - Move WebKitBuild to Build
Summary: Move WebKitBuild to Build
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-23 16:39 PST by Adam Barth
Modified: 2011-06-17 22:58 PDT (History)
4 users (show)

See Also:

Attachments
Patch (19.70 KB, patch)
2010-12-23 16:52 PST, Adam Barth 		eric: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-12-23 16:39:17 PST 
Move WebKitBuild to Build
Comment 1 Adam Barth 2010-12-23 16:52:58 PST 
Created attachment 77386 [details]
Patch
Comment 2 William Siegrist 2010-12-23 16:59:41 PST 
This will need to be tightly coordinated with buildbot since the slaves will immediately see the paths change but the master will not send the correct paths until it is updated.
Comment 3 Adam Barth 2010-12-23 17:01:24 PST 
Comment on attachment 77386 [details]
Patch

I figured that might be the case.  I'm not in a big rush to land this patch, but it seems like the direction we'd like to move in given the discussion on webkit-dev.
Comment 4 Eric Seidel (no email) 2010-12-23 19:21:43 PST 
Comment on attachment 77386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77386&action=review

Looks sane to me.  This could be a pain to get landed.

> JavaScriptCore/tests/mozilla/expected.html:461
> -js1_6/String/regress-306591.js
>  \ No newline at end of file

Are you sure this won't affect run-javascriptcore tests?
Comment 5 Adam Barth 2011-06-17 22:58:48 PDT 
I'm not sure this is worth doing.  The new name would be slightly better, but I'm not sure it's worth the hassle.